sahib / glyr Goto Github PK

View Code? Open in Web Editor NEW

245.0 245.0 23.0 7.41 MB

Glyr is a music related metadata searchengine, both with commandline interface and C API

License: GNU Lesser General Public License v3.0

CMake 1.65% C 91.17% Shell 0.10% Python 6.88% C++ 0.14% Dockerfile 0.06%

glyr's People

Contributors

Stargazers

Watchers

glyr's Issues

discogs fails to fetch covers

When trying to fetch a cover, discogs returns a 401 error:

% glyrc cover --from discogs --album oomph --artist oomph -v 4

Artist : oomph
Album : oomph
Language : fr
Type : cover

---- Triggering: discogs

Trying 70.103.226.21...
Connected to api.discogs.com (70.103.226.21) port 80 (#0)

GET /database/search?type=release&q=oomph HTTP/1.1
Host: api.discogs.com
User-Agent: libglyr/1.0-6 (Raving Raven) +https://www.github.com/sahib/glyr
Accept: /
Accept-Encoding: gzip
The requested URL returned error: 401 Unauthorized
Closing connection 0
glyr: Downloaderror: HTTP response code said error [errno:22]
On URL: http://api.discogs.com/database/search?type=release&q=oomph

Python bindings

There are already ruby bindings for glyr. It would be awesome to have python bindings as well.

Typo in README

"searcheninge" should be "search engine"

cache select always prints to STDERR

$ glyrc cache select lyrics -a "artist" -t "title" -w stdout --cache $HOME/.cache/glyrc 1>/dev/null

This prints data to STDERR.

$ glyrc cache select lyrics -a "artist" -t "title" -w stdout --cache $HOME/.cache/glyrc 1>/dev/null 2>&1

This prints nothing.

Seems to be because the cache query uses glyr_cache_print(), which doesn't get passed the output_path, and doesn't pass it on down.

As a result, cache queries don't obey -w/--write, while the lyrics getter does.

Deleting an entry from the cache is extreemly slow

time glyrc cover --drop -c ~/.cache/gmpc/metadata/ -a "Jon Lord" -b "Jon Lord blues project - Live"; time glyrc cover -c ~/.cache/gmpc/metadata/ -f "local:-all" -a "Jon Lord" -b "Jon Lord blues project - Live"
Deleted 1 item from cache.

real 0m11.167s
user 0m10.980s
sys 0m0.170s

Artist : Jon Lord
Album : Jon Lord blues project - Live
Language : us
Type : cover

---- Triggering: local

=> 0 item(s) in total.

real 0m0.012s
user 0m0.000s
sys 0m0.010s

--write option doesn't work

despite using
--write null
the output is being displayed.

Version 1.0.6 (Raving Raven) on debian jessie

Need some/more exit codes

My usecase:

% glyrc cover -a "Владимир Высоцкий" -b "Чёрные бушлаты"
- Artist   : владимир высоцкий
- Album    : чёрные бушлаты
- Language : ru
- Type     : cover

---- Triggering: musictree local coverartarchive 
---- Triggering: lastfm jamendo musicbrainz 
---- Triggering: slothradio lyricswiki discogs 
---- Triggering: rhapsody picsearch google 
% echo $?                                                       
0

I see, I don't get a cover. 'exit 0' looks fine, but not in the case.

glyr stable tarball

Please provide a tarball with stable version of glyr.
This is important for packages maintainers of various distributions.

Another typo

Several instances of "commnandline" remain. Sorry! Thanks for fixing all the other typos so fast.

chordie_com.c missing

The following file seems to be misssing:
lib/intern/guitartabs/chordie_com.c

QSRatio seems to behave strange

By setting it to 0.0 it queries slow and least quality providers first. Huh?

Deleting specific album cover deletes ALL album covers.

I setup a query with artist/album pair with type GLYR_GET_COVERART.
doing a delete on that, deletes all covers for that artist.

Version 1.0.6. Compilation error.

Compilation error in openSUSE:

 cd /home/abuild/rpmbuild/BUILD/glyr-1.0.6/build/lib && /var/lib/build/ccache/bin/cc  -Dglyr_EXPORTS -std=gnu99 -Wall -Wextra -Wstrict-prototypes -W -Wno-unused-parameter -Wno-strict-prototypes -fvisibility=hidden -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -D_GNU_SOURCE  -O3 -DNDEBUG -fPIC -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include    -o CMakeFiles/glyr.dir/core.c.o   -c /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/core.c
 In file included from /usr/include/glib-2.0/glib.h:95:0,
                  from /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/glyr.c:21:
 /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/glyr.c: In function 'guess_language':
 /usr/include/glib-2.0/glib/gversion.h:51:35: error: missing expression between '(' and ')'
        GLIB_MICRO_VERSION >= (micro)))
                                    ^
 /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/glyr.c:113:5: note: in expansion of macro 'GLIB_CHECK_VERSION'
  #if GLIB_CHECK_VERSION(2, 8, )
      ^
 /usr/include/glib-2.0/glib/gversion.h:51:35: error: missing expression between '(' and ')'
        GLIB_MICRO_VERSION >= (micro)))
                                    ^
 /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/glyr.c:148:7: note: in expansion of macro 'GLIB_CHECK_VERSION'
  #elif GLIB_CHECK_VERSION(2, 6, )
        ^
 lib/CMakeFiles/glyr.dir/build.make:54: recipe for target 'lib/CMakeFiles/glyr.dir/glyr.c.o' failed
 make[2]: *** [lib/CMakeFiles/glyr.dir/glyr.c.o] Error 1
 make[2]: *** Waiting for unfinished jobs....
 In file included from /usr/include/glib-2.0/glib.h:95:0,
                  from /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/stringlib.h:25,
                  from /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/core.c:24:
 /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/core.c: In function 'glist_free_full':
 /usr/include/glib-2.0/glib/gversion.h:51:35: error: missing expression between '(' and ')'
        GLIB_MICRO_VERSION >= (micro)))
                                    ^
 /home/abuild/rpmbuild/BUILD/glyr-1.0.6/lib/core.c:1555:5: note: in expansion of macro 'GLIB_CHECK_VERSION'
  #if GLIB_CHECK_VERSION(2, 8, )
      ^
 lib/CMakeFiles/glyr.dir/build.make:77: recipe for target 'lib/CMakeFiles/glyr.dir/core.c.o' failed
 make[2]: *** [lib/CMakeFiles/glyr.dir/core.c.o] Error 1
 make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/glyr-1.0.6/build'
 CMakeFiles/Makefile2:137: recipe for target 'lib/CMakeFiles/glyr.dir/all' failed
 make[1]: *** [lib/CMakeFiles/glyr.dir/all] Error 2
 make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/glyr-1.0.6/build'
 Makefile:117: recipe for target 'all' failed
 make: *** [all] Error 2

Can you help. please?

Return exit code based upon success

glyrc always returns 0. If it doesn't find any results, it should return 1 instead.

Crash when grabbing image from discogs

Backtrace:

---- Triggering: singerpictures 
[New Thread 0x7fffd6e47700 (LWP 3356)]
[Thread 0x7fffd6e47700 (LWP 3356) exited]
- glyr: Downloaderror: HTTP response code said error [errno:22]
  On URL: http://www.singerpictures.com/elmore-james-pictures.html
---- Triggering: discogs 
[New Thread 0x7fffd6e47700 (LWP 3358)]
[Thread 0x7fffd6e47700 (LWP 3358) exited]
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffe398a700 (LWP 3315)]
0x00007ffff3ae0b4a in ?? () from /lib/x86_64-linux-gnu/libc.so.6
(gdb) bt
#0  0x00007ffff3ae0b4a in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007ffff5446d9e in memmove (__len=<optimized out>, __src=<optimized out>, __dest=0x7fffdc0271c2) at /usr/include/x86_64-linux-gnu/bits/string3.h:57
#2  transform_url (s=0x7fffdc0116a0, url=0x7fffdc026d50 "http://s.pixogs.com/images/default-release.png") at /tmp/buildd/glyr-1.0.2/lib/intern/photos/discogs.c:84
#3  photos_discogs_parse (capo=0x7fffdc0116a0) at /tmp/buildd/glyr-1.0.2/lib/intern/photos/discogs.c:126
#4  0x00007ffff543b625 in call_provider_callback (capo=0x7fffdc0116a0, userptr=userptr@entry=0xd46240, stop_download=stop_download@entry=0x7fffe3989747, 
    to_add=to_add@entry=0x7fffe3989754) at /tmp/buildd/glyr-1.0.2/lib/core.c:1288
#5  0x00007ffff543ad5f in async_download (url_list=<optimized out>, endmark_list=<optimized out>, s=s@entry=0x7fffe3989ad0, parallel_fac=<optimized out>, 
    timeout_fac=<optimized out>, asdl_callback=asdl_callback@entry=0x7ffff543b5d0 <call_provider_callback>, userptr=0xd46240, free_caches=free_caches@entry=1)
    at /tmp/buildd/glyr-1.0.2/lib/core.c:884
#6  0x00007ffff543c23c in execute_query (fetcher=<optimized out>, result_list=0x7fffe39899e0, stop_me=0x7fffe39899dc, source_list=<optimized out>, 
    query=0x7fffe3989ad0) at /tmp/buildd/glyr-1.0.2/lib/core.c:1616
#7  start_engine (query=query@entry=0x7fffe3989ad0, fetcher=<optimized out>, err=err@entry=0x7fffe3989ac0) at /tmp/buildd/glyr-1.0.2/lib/core.c:1710
#8  0x00007ffff54390a3 in glyr_get (query=0x7fffe3989ad0, e=0x7fffe3989ac0, length=0x0) at /tmp/buildd/glyr-1.0.2/lib/glyr.c:929
#9  0x0000000000485704 in ?? ()
#10 0x0000000000000000 in ?? ()

Unable to query local db from commandline tool

glyrc cover -D -c ~/.cache/gmpc/metadata/ -v 4 -a "Jon Lord" -b "Jon Lord blues project - Live" -f "local"

Artist : Jon Lord
Album : Jon Lord blues project - Live
Language : us
Type : cover

---- Triggering: local

=> 0 item(s) in total.

while I am sure it is in there..
I need to query the local db to verify the correct working, if this is possible it would be very nice.

can not find libglyr.so.1 after "make install"

On ubuntu, I build from top of git repo. But, it can not find libglyr.so.1. I use the following step to cmake and install glyr:

$ cd glyr.git
$ mkdir build && cd build
$ cmake -DCMAKE_INSTALL_PREFIX=/home/leon/bin/glyr-git/ ../
$ make
$ make install

It failed to find libglyr.so.1

$ ldd ~/bin/glyr-git/bin/glyrc
linux-vdso.so.1 => (0x00007ffff47b7000)
libglyr.so.1 => not found
libglib-2.0.so.0 => /lib/x86_64-linux-gnu/libglib-2.0.so.0 (0x00007f6b584e8000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f6b58147000)
libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007f6b57f0b000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f6b57d02000)
/lib64/ld-linux-x86-64.so.2 (0x00007f6b58811000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f6b57ae5000)

$ ~/bin/glyr-git/bin/glyrc
/home/leon/bin/glyr-git/bin/glyrc: error while loading shared libraries: libglyr.so.1: cannot open shared object file: No such file or directory

Configuration file needed

Having to type --cache ~/.cache/glyrc every time is tiring. :)

Wrong lyrics for some songs

Try for example:

glyrc lyrics -a "Finntroll" -t "I Trädens Sang"

Output:

Lad' dir den Song kostenlos runter!

Mit der Napster Musikflatrate exklusiv bei magistrix für 30 Tage kostenlos!

This doesn't seem to be a lyrics for this song..

Local cache is dodgy at best.

The local cache does not seem to work as it should. This happens on my main develop pc. (ubuntu 11.04).
I open gmpc, let it get all metadata, close it. open it again, then it refetches large parts.:

Also if I let gmpc insert an entry in the db, it will not find that, and requery it. This is driving me absolutely nuts and makes developing in gmpc/glyr almost impossible atm.

gmpc: could not connect to socket
gmpc: No such file or directory
-:1: error: invalid string constant "dark", expected valid string constant
open glyr db: /home/qball/.cache/gmpc/metadata
db: 0x1507900
playlist3 zoom level changed

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Tracks And Lines
Language : us
Type : artistphoto

---- Triggering: local

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Tracks And Lines
Language : us
Type : cover
Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
---- Triggering: local
Title : Tracks And Lines
Language : us
Type : artistphoto

---- Triggering: musictree local lastfm singerpictures

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : backdrops

---- Triggering: local

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : lyrics

---- Triggering: local
Try querying cache
cache: (nil)
start query
Try querying cache
new style query
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Tracks And Lines
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : artistphoto

---- Triggering: local
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : artistphoto

---- Triggering: local

Artist : Clapton, Eric
Album : 24 Nights
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Apartment Jam
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : A Tribute to Stevie Ray Vaughan
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : August
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Blood Brother
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Bradley Center, Milwaukee
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : From the Cradle
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Just One Night
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Knockin' On Heaven's Door
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : Madison Square Garden, New York City, New York
Language : us
Type : cover

---- Triggering: local

Artist : Clapton, Eric
Album : One More Car, One More Rider
Language : us
Type : cover

---- Triggering: local
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query
Try querying cache
cache: (nil)
start query

glyr: Downloaderror: HTTP response code said error [errno:22]
On URL: http://www.singerpictures.com/clapton-eric-pictures.html
#[-2/01] DB lookup found 2 dupes
---- Triggering: discogs rhapsody picsearch flickr
#[-6/01] DB lookup found 6 dupes
---- Triggering: google
#[-2/01] DB lookup found 2 dupes
Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Tracks And Lines
Language : us
Type : cover

---- Triggering: musictree local lastfm albumart
--- Inserted 1 item into db.

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : backdrops

---- Triggering: musictree local htbackdrops

[-2/01] DB lookup found 2 dupes

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : cover

---- Triggering: musictree local lastfm albumart
--- Inserted 1 item into db.

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : lyrics

---- Triggering: musictree local lyricswiki lipwalk

[01/01] Checking encoding [.](-0 item%28s%29 less)

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Tracks And Lines
Language : us
Type : cover

---- Triggering: musictree local lastfm albumart
--- Inserted 1 item into db.

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : cover

---- Triggering: musictree local lastfm albumart
--- Inserted 1 item into db.

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : artistphoto

---- Triggering: musictree local lastfm singerpictures
Cache is Empty
new style query
glyr_return_queue: results
Provider: musictree
new style query
glyr_return_queue: results
Cache is Empty
new style query
glyr_return_queue: results
Provider: musictree
new style query
Provider: lyricswiki
new style query
Provider: musictree
new style query
glyr_return_queue: results
Provider: musictree
new style query
glyr_return_queue: results
glyr_return_queue: results
glyr_return_queue: results

glyr: Downloaderror: HTTP response code said error [errno:22]
On URL: http://www.singerpictures.com/clapton-eric-pictures.html
#[-2/01] DB lookup found 2 dupes
---- Triggering: discogs rhapsody picsearch flickr
#[-6/01] DB lookup found 6 dupes
---- Triggering: google
#[-2/01] DB lookup found 2 dupes
Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : cover

---- Triggering: musictree local lastfm albumart
--- Inserted 1 item into db.

Artist : Clapton, Eric
Album : Rush: Music From The Motion Picture Soundtrack
Title : Help Me Up
Language : us
Type : artistphoto

---- Triggering: musictree local lastfm singerpictures

glyr: Downloaderror: HTTP response code said error [errno:22]
On URL: http://www.singerpictures.com/clapton-eric-pictures.html
#[-2/01] DB lookup found 2 dupes
---- Triggering: discogs rhapsody picsearch flickr
Cache is Empty
new style query
glyr_return_queue: results
Provider: musictree
new style query
glyr_return_queue: results
#[-6/01] DB lookup found 6 dupes
---- Triggering: google
#[-2/01] DB lookup found 2 dupes
Artist : Clapton, Eric
Album : 24 Nights
Language : us
Type : cover