saif-ellafi / foundryvtt-mythic-gme Goto Github PK

As discussed in #6 :

The Mythic Supplement "Location Crafter" is great system for creating believable and coherent randomly generated locations, areas and regions.

Afaik there are two different variations of it around: The one from the Location Crafter book and a simpler version in Mythic Magazine Vol 2 with additional material in Vol 5 and 7.

Implementation here would be a first iteration following the simplified rules in Mythic Magazine Vol 2 (and maybe 5+7), with the original full variation to be assessed later.

The focus should be on easy and fast usage during a session, regardless of solo-play or gm-based.

nvm I am dumb

same cause as #3 I guess but with https://github.com/fvtt-fria-ligan/vaesen-foundry-vtt

Foundry 9.280, Mythic 2.5.13, vaesen 2.3.6 (latest for v9)

I don't know enough how foundry works yet to be able to help.

Only two modules activated : dice so nice and Mythic GME (problem happens also without dice so nice)

Nothing happens in chat.

Errors are :

foundry.js:319 Error: Unable to recreate Roll instance from provided data
    at Roll.fromJSON (foundry.js:7554:23)
    at get roll [as roll] (foundry.js:14989:27)
    at ChatMessage._renderRollContent (foundry.js:15333:73)
    at ChatMessage.getHTML (foundry.js:15284:18)
    at ChatLog.postOne (foundry.js:57887:32)
    at ChatMessage._onCreate (foundry.js:15357:12)
    at ClientDatabaseBackend.callback (foundry.js:10093:11)
    at foundry.js:10043:43
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleCreateDocuments (foundry.js:10043:33)
onError @ foundry.js:319
get roll @ foundry.js:14992
_renderRollContent @ foundry.js:15333
getHTML @ foundry.js:15284
postOne @ foundry.js:57887
_onCreate @ foundry.js:15357
callback @ foundry.js:10093
(anonymous) @ foundry.js:10043
_handleCreateDocuments @ foundry.js:10043
_createDocuments @ foundry.js:9939
await in _createDocuments (async)
create @ backend.mjs:96
await in create (async)
createDocuments @ document.mjs:338
create @ document.mjs:439
toMessage @ foundry.js:7441
callback @ mythic-gme-tools.js:1037
submit @ foundry.js:44151
_onClickButton @ foundry.js:44114
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
foundry.js:319 Error: Unable to recreate Roll instance from provided data
    at Roll.fromJSON (foundry.js:7554:23)
    at get roll [as roll] (foundry.js:14989:27)
    at main.js:205:49
    at Hooks._call (foundry.js:294:14)
    at Hooks.callAll (foundry.js:253:12)
    at ClientDatabaseBackend.callback (foundry.js:10105:13)
    at foundry.js:10043:43
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleCreateDocuments (foundry.js:10043:33)
    at ClientDatabaseBackend._createDocuments (foundry.js:9939:17)
onError @ foundry.js:319
get roll @ foundry.js:14992
(anonymous) @ main.js:205
_call @ foundry.js:294
callAll @ foundry.js:253
callback @ foundry.js:10105
(anonymous) @ foundry.js:10043
_handleCreateDocuments @ foundry.js:10043
_createDocuments @ foundry.js:9939
await in _createDocuments (async)
create @ backend.mjs:96
await in create (async)
createDocuments @ document.mjs:338
create @ document.mjs:439
toMessage @ foundry.js:7441
callback @ mythic-gme-tools.js:1037
submit @ foundry.js:44151
_onClickButton @ foundry.js:44114
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
foundry.js:297 Foundry VTT | Error thrown in hooked function '' for hook 'createChatMessage'
_call @ foundry.js:297
callAll @ foundry.js:253
callback @ foundry.js:10105
(anonymous) @ foundry.js:10043
_handleCreateDocuments @ foundry.js:10043
_createDocuments @ foundry.js:9939
await in _createDocuments (async)
create @ backend.mjs:96
await in create (async)
createDocuments @ document.mjs:338
create @ document.mjs:439
toMessage @ foundry.js:7441
callback @ mythic-gme-tools.js:1037
submit @ foundry.js:44151
_onClickButton @ foundry.js:44114
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
foundry.js:319 TypeError: Cannot read properties of null (reading 'dice')
    at main.js:235:14
    at Hooks._call (foundry.js:294:14)
    at Hooks.callAll (foundry.js:253:12)
    at ClientDatabaseBackend.callback (foundry.js:10105:13)
    at foundry.js:10043:43
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleCreateDocuments (foundry.js:10043:33)
    at ClientDatabaseBackend._createDocuments (foundry.js:9939:17)
    at async ChatMessage.createDocuments (document.mjs:338:21)
    at async ChatMessage.create (document.mjs:439:21)
onError @ foundry.js:319
_call @ foundry.js:298
callAll @ foundry.js:253
callback @ foundry.js:10105
(anonymous) @ foundry.js:10043
_handleCreateDocuments @ foundry.js:10043
_createDocuments @ foundry.js:9939
await in _createDocuments (async)
create @ backend.mjs:96
await in create (async)
createDocuments @ document.mjs:338
create @ document.mjs:439
toMessage @ foundry.js:7441
callback @ mythic-gme-tools.js:1037
submit @ foundry.js:44151
_onClickButton @ foundry.js:44114
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2
backend.mjs:306 Foundry VTT | Created ChatMessage with id [yXgxlHoP8CCkgPfD]
foundry.js:15333 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'total')
    at ChatMessage._renderRollContent (foundry.js:15333:78)
    at ChatMessage.getHTML (foundry.js:15284:18)
    at ChatLog.postOne (foundry.js:57887:32)
    at ChatMessage._onCreate (foundry.js:15357:12)
    at ClientDatabaseBackend.callback (foundry.js:10093:11)
    at foundry.js:10043:43
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleCreateDocuments (foundry.js:10043:33)
    at ClientDatabaseBackend._createDocuments (foundry.js:9939:17)
    at async ChatMessage.createDocuments (document.mjs:338:21)

Is it possible to remember the last options selected for the Export chat to Journal macro window?

For example

• If I enter in a custom journal, remember the value and append to that.
• If I select Include Actor Images or clear chat, remember the value

Howdy! Love the module, really fantastic and the latest update bringing the tool HUD is amazing! Something I didn't realize in the time I've used it solo till today, if you're running a group and just like using it, it'll show up on the screen for everyone. No way to close it, hide it, etc.
So I think it'd be a great feature to include a permissions setting for it, so it only shows up if you have permissions for it, so it'll work dandy for guided, co-op, or solo games!

Thanks for reading!

I think Immitate should be Imitate?

Super minor but saw it on a random roll I did. Random Event macro selected the Mythic GME: Event Focus from the dropdown and the attached image was the result.

Happy Gaming!

Could you please add an option to either append to a journal or overwrite all content therein?

Please add feature to have the option to automatically get rolls for privately to GM. It helps with playing with other people, not having to switch private/public

When I click on oracles like "Actions", it immediately adds a card to chat. However, it takes about 7 seconds before it is updated with the first word, and about 2 more seconds before it is updated with the second word.

I imported the Random Event macro but when I try to run it, I get:

mythic-gme-tools.js:443 Uncaught (in promise) TypeError: Cannot read property 'timeBeforeHide' of undefined
    at Function._mgmeSubmitOracleQuestion (mythic-gme-tools.js:443)

Could you please add the scene alteration method from Mythic Magazine #2: Pages 4-7?

I love what you have done with this module so far. I started with an implementation of the Mythic Adventure Crafter to use in a gamemaster less tabletop game. I am using Mythic Variation 2 and created the tables for the Turning Points as described in Adventure Crafter. A Turning Point is used instead of a random event, if the Variations 2 and Adventure Crafter a mixed.

For the Turning Point I need https://github.com/ultrakorne/better-rolltables because 4 results need to be generated for a single Turning Point. I created a table as replacement for the Event and used the settings to have it used instead of the standard table.

The culprit is, that the module uses the standard tables or the standard way to get the results. This leads to a single result retrieved from my better-rolltable regardless what I do. I tried to figure out how to easily support better-rolltables, but came to the conclusion to ask for help before continuing.

Do you plan to support Mythic Adventure Crafter?

Or is it possible to support better-rolltables and add multiple results from a table roll to the Chat? I tracked it down to the method _mgeGetOracleAnswers. There you use

const focusTable = await _mgeFindTableBySetting('focusTable');
focusRoll = await focusTable.roll();
focusResult = focusRoll.results[0].getChatText();

with https://github.com/ultrakorne/better-rolltables/wiki/API-for-macros-and-modules the results are directly added to the chat and not returned. After checking the source basically the better-rolltables API is not enough, but the results need to be retrieved with code like in betterTableRoll method.

Maybe better-rolltables is useful for this module as well, as it provides some nice features for more complex table design.

Hi, the order of the values of Background table don't match with the Mythic GME 2e book. Rolling between 10 and 100 the values are adding a +1, altering the value of the table.
For example:
If I roll a 20, I look the Mythic Book and the value corresponds to "Combat". The FoundryVTT module with a 20 gives me a value of "Commitment" but this value corresponds to 21 according to the book.
I've noticed that between 1 to 9 there is no problem with the module, it matches with the Mythic Book value. When rolling a 100 the module gives an empty value instead of "Youth".

I was reviewing the database and it seems that you have skipped the word "Bad" on this table that corresponds to the 10 on the Mythic GME 2e Book. This is the reason of why the 100 value does have a empty value.

Could you please add the Simplified behavior checks system from Mythic Magazine #1: Page 8-18?

I realize you probably haven't gotten to version 10 compatibility issues yet, but thought I would go ahead and submit this.

By the way - everything else seems to be working pretty well so far in v10!

Not sure if this is the right place or not.
I found an issue with the GMA Deck Tables. The Table Results columns are missing GMA XXX VTT_part110.

Hello, and thanks for the great work so far.
Would it be possible to add an option to change font colors within the module? I am using the Warhammer modules. Unfortunately most of the backgrounds are black, so it is often not possible to read the fonts within zhe boxes (see screenshot).

Thanks a lot,
Kai

In the settings I have it set to display the roll values but it is not showing the roll numbers in chat for any of the meanings rolls. It does for Event Focus and Fate Questions and things up above, but all meanings do not.

Hi there!

Is the Acting Rank Vs Difficulty Rank chart (Miniscule 2+ -Superhuman 2+ ) from the Mythic Red Book already included?
If not, could you add it?

The clear chat after export option shown below doesn't work.

The content is exported but the chat is not cleared.

Hi, thanks for this module !

I'm testing in foundry v9 build 280.

When installing your module, it is the latest that is installed (2.6.1) and a warning popup appears in foundy saying that this module does not publish compatibility data or something like that (the message only appears a brief moment).
When using this version, when checking for scene alteration for example, if a random event appears and several dice rolls happen in a row, only two messages appear : an undefined one and the latest one which gets overwritten with each dice roll.

Here is the only error in console :

I tried to uninstall and force a downgrade of your module (using a json module direct link) to version 2.5.12 (before v10 compatibility), this version works flawlessly.

Is there a way when installing your module, to pin versions that are compatible ? (I don't know foundry well, I'm just beginning).
For example is user if on foundry v10, the latest module is downloaded, but if user is on v9 only 2.5.x versions are downloaded ?

Thanks again !

I tried every chaos number and I can't do a Fate question of impossible or nearly impossible. Also when I press on the Character list it keeps creating new options called [Choose, or roll again]. I am from brazil so sorry if any there is any grammar errors. Come to Brazil ;)

When this module is enabled, the escape key no longer functions. Normally the escape key will deselect actors, close dialogs and, finally, bring up the foundry menu. It is not possible to do any of these things when the module is enabled. Not sure if this is related, but there is also no ability to close the mythic window, it can only be minimized.

Error in console:
mythic-gme-tools.js:1680 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'tokens') at Function.mgmeFormattedChat (mythic-gme-tools.js:1680) at eval (eval at _executeScript (foundry.js:16970), <anonymous>:4:50) at Macro.eval (eval at _executeScript (foundry.js:16970), <anonymous>:5:7) at Macro._executeScript (foundry.js:16972) at Macro.execute (foundry.js:16929) at Hotbar._onClickMacro (foundry.js:52384) at HTMLLIElement.dispatch (jquery.min.js:2) at HTMLLIElement.v.handle (jquery.min.js:2) mgmeFormattedChat @ mythic-gme-tools.js:1680 eval @ VM302:4 eval @ VM302:5 _executeScript @ foundry.js:16972 execute @ foundry.js:16929 _onClickMacro @ foundry.js:52384 dispatch @ jquery.min.js:2 v.handle @ jquery.min.js:2

Attached console log and screenshot of said console output

I'm running Foundry version 0.8.9.

127.0.0.1-1636150700422.log

Now that v2 has been published, do you have plans for integrating it into this awesome project?

As discussed in #6 :

The Mythic Supplement "Creature Crafter" is great system for creating believable and coherent randomly generated creatures, aliens and monsters.

Afaik there are two different variations of it around: The one from the Creature Crafter book and a simpler version in Mythic Magazine Vol 13.

Implementation here would be a first iteration following the simplified rules in Mythic Magazine Vol 13, with the original full variation to be assessed later.

The focus should be on easy and fast usage during a session, regardless of solo-play or gm-based.

@saif-ellafi I have loaded the files into the appropriate folder but for some reason I am receiving a 404 error when the macro looks for the cards. It does pull the card # and if it is reversed/flipped but no image is shown. This occurs both locally on my machine and when I use the macro on The Forge setup I have too. The one difference on The Forge is that I cannot get the decks folder in the User Data folder so the deck data/images is only in the My Assets folder on The Forge setup.

Can you help me figure out why the macro can't find the card images regardless of where the Foundry VTT module points to the files.

On my local setup it is exactly as the installation instructions show and it still throws a 404 error. The Forge and Foundry help teams noted that the applications will look for the data where it is directed so their thought is that the macro may need to be changed to account for the change in location from User Data to My Assets folder. However, I can't seem to see where the macro might be doing that.

Thanks for your help!

The "PC Positive" result (roll range of 81-85 for 1d100) under Random Event Focus Table is missing under the "Mythic GME: Event Focus (2e)" table. Also, it seems when 2nd Edition rulebook is selected, the "Random Event" button still leads to 1st edition Event Focus table instead of the 2nd edition version table.

I have an issue, that all my GMA card decks are sheets. 6 cards to a sheet.
MY issue is: I can cut them with gimp, but what names do they need to be for each card, what format should I save them as? [png, Jpg .... ???] and how do I set up this folder for them?
I would appreciate your help any way you can. Thank you for a great GMA add on, I just don't
know how to set my sheets up for this, :D

Foundry V11 introduced a build in compendium structure, use it to reduce clutter in the compendium tab

I'll create a PR with changes today

Hey,

I'm not sure this is something you planned or not (or have the right to do), but would you be inclined to provide features for the Mythic supplements for creating Creatures, Locations and Adventures? Especially the second two would be immensely interesting to non-solo games and sessions as well, as they can be used by GMs to help generate content during a session.

Just to be sure: I'm more talking about a way to keep track of the results above, less the actual rules to put in. For the Adventure Crafter that would be Plots and Scenes, etc, for the Location Crafter that would be to keep track of the three lists, as well as progressing.

Thanks for the work on this in any case :)

Hello! Thank you so much for your amazing work, first of all!
That Coffee must be sum amazeeng stuff!

DiceBox.js:544 Uncaught TypeError: Cannot read properties of null (reading 'shape')
[Detected 1 package: dice-so-nice]
at DiceBox.getVectors (DiceBox.js:544)
at DiceBox.js:1042
at Array.forEach ()
at DiceBox.start_throw (DiceBox.js:1028)
at Dice3D.js:600
at Dice3D.js:433

Let's cut to the chase: This is the error I see in the console whenever I try - for example - to use the Random Event Macro with Dice so nice, and basically any Macro which calls for a RollTable.
What does it mean?
Is this the reason the Macros are mostly not working if I have Dice so Nice loaded?
What can I do to fix it?

As discussed in #6 :

The Mythic Supplement "Adventure Crafter" is great system for creating believable and coherent randomly generated plots, scenes and full Adventures.

Afaik there is only a single variation of it: The one from the Adventure Crafter book, but there are some additional elements in the Mythic Magazines, as well as a slightly simpler version using the Adventure Crafter Card Deck.

Implementation here can be any of the versions, but as support for the Card Decks is already available, it seems this is the version to start with, and the original full variation to be assessed later.

The focus should be on easy and fast usage during a session, regardless of solo-play or gm-based.

2.8.4 seems to have introduced a bug where Oracles like Actions only produce a single word instead of a pair (e.g. "Suffering")

Hey, I'm interested in using this tool with prepared adventures, but in order to do so I'm going to need that table. For now I'll have to have the table up externally, which is a minor inconvenience but would be nice to have integrated.

I am using Real Dice module for manual roles:
https://foundryvtt.com/packages/real-dice

However, it works not with the Fate questions. Can you have a look? It seems it is not using the standard Foundry dice rolling mechanism.

Alternatively, can we have a manual dice roll mode like the module above?