GithubHelp home page GithubHelp logo

lowdb-google-cloud-storage-adapter's People

Contributors

saleehk avatar

Watchers

 avatar  avatar

lowdb-google-cloud-storage-adapter's Issues

Move babel-polyfill under dependencies

Hi, First i would like to appreciate for the hardwork. I tried this, but I have some issues in making it work right for me. I will try a little more and get back on that. But i observed this is one among them.

I see you are using babel-polyfill in your file by require. So, it should be under dependencies in your package.json file and not in devDependencies.

Reason

devDependencies are not installed when a client tries to install the package in their project. So it ends up creating errors if the user is not having ``babel-polyfillin thenode_modules`

It works in some projects

If you run

npm ls babel-polyfill

in such repositories, you can see either any of other dependencies might be using it. So the index.js file might pull from there.

How it misses in local development?

In local at the time of development, we install both dependencies and devDependencies as well, so during the development phase, we won't come across this issue.

Here is a tool to quickly test these edge cases --> https://www.pika.dev/cicd

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.