saltyfacu / ape-tax Goto Github PK
View Code? Open in Web Editor NEWHome Page: https://ape.tax
Home Page: https://ape.tax
As discussed @saltyfacu
DAI 0.4.5 vault created here:
https://optimistic.etherscan.io/address/0x780210e8826064b94e71f5b7bbb73d92637c48d6
It would be useful for discovery to have a switcher or a dropdown which allows connecting to chains where ape.tax is available.
Metamask has an RPC method to add/switch chains
https://docs.metamask.io/guide/rpc-api.html#wallet-addethereumchain
The needed metadata can be obtained here
https://chainid.network/chains.json
I figured it out
In VaultDetails.tsx
in the Deposit Limit:
section we have a condition that either shows -
when the vault depositLimit is 0 or it shows the vault limit rounded to 2 decimal places.
In the specific case where a vault limit is the largest possible unsigned number (MAX_UINT_256
) deposit limit of the vault is show as below, which can be improved.
We should adjust this condition to show Deposit Limit: โ
in the case the vault returns a limit greater than or equal to MAX_UINT-256
as seen below.
Better overall user experience for this specific case
When you think you have the right condition you can test by declaring a variable like seen below and using it instead of the actual vaultData.depositLimit.raw
value to see if you UI shows properly.
When approving the vault, the approve button stays on and never enables deposits.
Vault: https://ape.tax/fantombaby
Total AUM and APR are not shown correctly in vaults v3. This is what's shown on the website, but is incorrect:
Total AUM: $0.00
Gross APR (last week): Infinity%
Gross APR (last month): Infinity%
Gross APR (inception): 100000000000000000000.0000%
Go to: https://ape.tax/pearl-v3-usdc
Connect a wallet
Check the data above
No response
On the Ape API, the data are cached for 10 minutes.
We should add an optional param to force the revalidation when the user asks for it.
To avoid abuse on this, maybe we should build it with the requester AlchemyKey (so it's the requester usage and not "we")
Description:
This strategy links https://ape.tax/fantombaby with https://ape.tax/fantomsfury
A ProviderStrategy
in each vault will provided a usd fixed amount (5k usd) to a Joint
contract which will provide liquidity to ICE/WFTM and farm ICE tokens. Once enough profit is made, the strategy will be liquidated and funds return.
Commit (hash): poolpitako/joint-strategy@7834b51
Tag:
Repo: https://github.com/poolpitako/joint-strategy
Scope: (List link to files)
Additional References or Repo (Link to underlying protocols or relevant documents):
Deployed Contract (etherscan link):
Review Ongoing By:
Review Completed By:
Using https://github.com/yearn/yearn-meta show a description of each strategy
On the Ape API, we are using Alchemy to get our vaults data. If the requester wants to, we should provide a way to override our rate-limited
key with it's custom key. This will limit third party limitation due to our cache stuff
Add support for v3 Ape.Tax test vaults
A clear and concise description about why this is a nice to have.
N/A
Currently we have a wagmiConfig.ts
file (utils/wagmiConfig.ts
) the file imports chain details then passes them to the configureChains()
function which tells our app which chains ape tax should support.
We should follow the good example set by the big brains at SmolDapp! This can be done by separating out all the specific chain details objects into their own file probably called wagmiChains.ts
then exporting them similar to what is shown here:
https://github.com/SmolDapp/smoldapp/blob/main/utils/wagmiChains.ts
Increases ease of reading and understanding the config file by moving chain specific details to a new file that only contains these chain specific details.
Make this adjustment on feat/v3-new
branch please
There will be no visual change to the app since this is just a change to overall organization / structure.
Description: This strategy stakes 3EPS in the staking pool.On harvest it gets the rewards, exits early, swaps EPS to BUSD then adds liquidity to 3EPS with single sided deposit with BUSD.
Commit (hash): a86197d2e4ec02fc57283b659dfc04b578b001af
Tag: master
Repo: https://github.com/akshaynexus/yearnv2-3poolellipsis-strat/
Scope: (List link to files)
Additional References or Repo (Link to underlying protocols or relevant documents):
Deployed Contract (etherscan link):
Review Ongoing By:
Review Completed By:
We have a local versions of useWindowInFocus
hook but there is also an equivalent hook in web-lib.
ours: https://github.com/saltyfacu/ape-tax/blob/master/hook/useWindowInFocus.tsx
web-lib's: https://github.com/yearn/web-lib/blob/main/packages/web-lib/hooks/useWindowInFocus.tsx
Seems like we can update local imports to use web-lib instead, then remove the local hook from the repo
Trade off of reducing local code, but increasing dependence on web-lib. Should be fine to do this.
Zap in is allowing the user to zap 0 funds, it shouldn't alow it.
Use WAGMI
A clear and concise description about why this is a nice to have.
N/A
Do we want to add strategies to the API? Is it worth it?
Currently you can see production vaults included in the Eth tvl number, but it would be nice if this was just the sum of tvl in experimental/non-prod vaults. Maybe a fix could be to make two page views one with vaults moved to prod, one with ape vaults and have tvl on both, or just sum tvl from non-prod vaults.
I noticed that our Deploy your own vault
button doesn't look quite as nice on small screens.
I think this should be done similar to how we change the title of our home page by showing one option on larger screens, then use media queries to show another option on small screens. I've included below and idea of what I think the final result should look like.
Add the doc of the API to the README file. Reference: #100 (comment)
When I open ape.tax using Arbitrum (an unsupported chain id), the site hangs saying "Loadgin Ex2". The console shows:
Uncaught (in promise) e: Unsupported chain id: 42161. Supported chain ids are: 1,56,137,250,1337.
at https://ape.tax/_next/static/chunks/pages/_app-778eacfcaeaafa42e331.js:1:179453
Expected behavior
Show something saying: change network.
Description:
Based on the MasterChef strategy from @Grandthrax and my own mir-ust strategy, it's extending the strategy to support LP tokens that needs an additional swap, adding liquidity to the liquidity pool, and depositing back into Masterchef.
The plan is to farm pancakeswap and ramenswap.
Commit (hash): 56331e3e686b468b1ff5a3c0205e53d347d018b7
Tag:
Repo: https://github.com/steffenix/yearnv2-masterchef-LP-token-generic
Scope: (List link to files)
Additional References or Repo (Link to underlying protocols or relevant documents):
Deployed Contract (etherscan link):
https://github.com/Grandthrax/yearnv2-masterchef-generic
https://github.com/steffenix/yearn-strategy-mir-ust
Review Ongoing By:
Review Completed By:
I believe the vault is not setup properly with https://www.coingecko.com/en/coins/spookyswap
Live vault used to have a custom UI with more functionality. I will elaborate later. Just want to track this now.
When the RPC that the user has for Fantom is not compatible with our APY calculations, suggest to change it to rpc.ftm.tools
.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.