sam-izdat / govote Goto Github PK

@wizardishungry - I reverted schulze.go to its previous state before your commit, because I was getting erroneous poll results. I'm afraid I don't have time to investigate at the moment. The test on the main README gave the following output when parallelized:

[Memphis] [{Memphis 3} {Nashville 2} {Chattanooga 1} {Knoxville 0}]

The expected output is :

[Nashville] [{Nashville 3} {Chattanooga 2} {Knoxville 1} {Memphis 0}]

At a cursory glance, I don't know if this is maybe a race condition or a more trivial bug. Let me know if you figure out and I'll add the feature back. Thanks.

Testing schulze / instant-runoff, I notice that when using partial ballots the values not present in any ballot are heavily favored as winners.

I think this fixes the behavior for instant-runoff:

 func (p *InstantRunoffPoll) runRound(elim map[string]bool) map[string]int {
    tally := make(map[string]int)                // scores keyed by candidate name
+   for _, c := range p.candidates {
+        if !elim[c] {
+            tally[c] = 0
+        }
+   }

I haven't looked into schulze yet.

What do you think?