sameerkumar18 / geek-joke-api Goto Github PK

Failed to load https://geek-jokes.sameerkumar.website/api: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:4200' is therefore not allowed access.

Angular 6
HttpClient
default HttpGet
Other api-s work

Hi, I opened #26 to suggest removing the .pyc file from your repo. This is a compiled file which shouldn't need to be versioned, and best practice is not to include files like this in your repos. The addition of the .gitignore will keep it from being added in future pushes. There are also some other best practice examples listed in the .gitignore as well. Please let me know what you think.

I wrote this code about 4 months ago when I was trying to implement REST in Flask API.
I think the code can be improved a lot.

It'll be great if someone could write the documentation for the API.
I wrote docs for an API previously, for reference - https://github.com/sameerkumar18/aztro/blob/master/docs/source/index.rst

I think the API needs more jokes. Currently, there are around 500 or so.
You can add geek jokes in the .json file.

(Do add the reference to the source in description of the pull request, if you're taking the content(joke) from somewhere else)

I would like to create a web application using this API. But Jokes are lame :/ .

It is a bad practice to perform any I/O operation while processing request so print joke statement should be removed.