samuelcabralcruz / unresolved-review-threads

GitHub Action to prevent the merge of pull request having unresolved review threads

Hi there, I am Samuel Cabral Cruz 👋

I'm a problem solver and software engineer living in Québec, Canada.

• 🔭 I’m currently working at Ingeno.

Languages & Tools

Certifications

For more details, here is my resume (EN | FR)

---

unresolved-review-threads's Issues

Explanation for the example workflow file in the readme?

As I was reviewing your action, I was curious about the event triggers you chose:

  pull_request_review_comment:
    types: [edited, deleted]

  pull_request_review:
    types: [submitted, edited, dismissed]

  pull_request:
    types: [opened, reopened, labeled, unlabeled, synchronize, review_requested, review_request_removed]
    branches:
      - main

• pull_request_review_comment: Why not check created as well? Can editing change the resolution of a comment?
• pull_request_review: I submitting and dismissing will cover the bulk comments that come with review (I assume all review comments disappear after dismissing a review). Is edited useful?
• pull_request: Is there any need to have anything except opened, labeled, unlabled here to get the initial status?

It seems maybe we're being over eager in target choices just to have more chances to get a status update without the user having to remove the label themselves? That makes sense though might increase check latency. I wonder how it feels in practice.

Either way, it seems good to update the readme with the reasons since it's after reading your rather good write up I wasn't quite sure how all the event targets were related other than as mentioned above!

Cheers!

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update Actions to v4 (actions/cache, actions/checkout, actions/setup-node)
• Update GitHub (@actions/core, @actions/github, @octokit/rest, @octokit/types)
• Update Lint (@typescript-eslint/eslint-plugin, @typescript-eslint/parser, eslint, eslint-config-prettier, eslint-import-resolver-typescript, eslint-plugin-import, eslint-plugin-prettier, eslint-plugin-simple-import-sort, eslint-plugin-unused-imports, prettier)
• Update Test to v29 (@types/jest, jest, ts-jest)
• Update Tools (@types/faker, d2l-license-checker, faker, husky)
• Update Typescript (@types/node, typescript)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/ci.yml

• actions/checkout v2
• actions/setup-node v2
• actions/cache v2

.github/workflows/test-usage.yml

• actions/checkout v2

npm

package.json

• @actions/core 1.2.6
• @actions/github 4.0.0
• @octokit/rest 18.5.2
• @octokit/types 6.13.0
• @types/faker 5.5.1
• @types/jest 26.0.22
• @types/node 14.14.37
• @typescript-eslint/eslint-plugin 4.21.0
• @typescript-eslint/parser 4.21.0
• d2l-license-checker 3.2.0
• eslint 7.24.0
• eslint-config-prettier 8.1.0
• eslint-import-resolver-typescript 2.4.0
• eslint-plugin-import 2.22.1
• eslint-plugin-prettier 3.3.1
• eslint-plugin-simple-import-sort 7.0.0
• eslint-plugin-unused-imports 1.1.1
• faker 5.5.3
• husky 6.0.0
• jest 26.6.3
• prettier 2.2.1
• ts-jest 26.5.4
• typescript 4.2.4

nvm

.nvmrc

---

• Check this box to trigger a request for Renovate to run again on this repository