GithubHelp home page GithubHelp logo

assignment2's People

Contributors

sanderspies avatar

Watchers

 avatar  avatar

assignment2's Issues

NewsList contains too much

It should be stripped from user actions which should be handled separately, however for this exercise it's good enough.

Description should be parsed

Sometimes a description contains an image, and sometimes it doesn't - it's rather unpredictable. Ideally the description should be parsed and a "good description" should be created from it.

Adding an image is relatively simple - it's just adding another tag. The handling of bad JSON input is the real problem here.

Remove breadcrumb

Initially I wanted to use a breadcrumb, however I preferred the transitions and back button. Which means that the breadcrumb is a bit of an overkill - and the titles could be moved towards NewsList and NewsArticle. This would also make the transitions simpler.

Add tests

Everything is ready to add tests, so it should be fairly simple to do so.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.