sandglaz / maktoub Goto Github PK

Steps Followed

->Added gem in gemfile
->Created configuration file in initializers folder with name maktoub.rb
->uncommented code in maktoub.rb
-> created a partial named _news.html.erb containinng normal html
->Then added mail setting in development.rb
-> Then run on my console Maktoub::NewsletterMailer.publish('news', name: 'User name', email: '[email protected]')

error comes
Maktoub::NewsletterMailer#publish: processed outbound mail in 25.3ms
ActionView::MissingTemplate: Missing template maktoub/newsletters/news with "mailer". Searched in:

• "maktoub/newsletters"

Do i need to create any other template ?

I am testing maktoub with delayed jobs. but I am having some issues. Could you please help.

rake maktoub:test['welcome']
...
2014-01-16T20:22:53-0800: [Worker(delayed_job host:ubuntu pid:4342)] Job Class#publish (id=24) RUNNING
Rendered maktoub/newsletters/welcome.erb within layouts/maktoub/newsletter_mailer (0.9ms)
Rendered layouts/maktoub/_styles.erb (0.4ms)
2014-01-16T20:22:53-0800: [Worker(delayed_job host:ubuntu pid:4342)] Job Class#publish (id=24) FAILED (0 prior attempts) with ActionView::Template::Error: No route matches {}
...

Does it generate unsubscribe link? As a bool attribute within user model?
Does it support rails 4?

the maktoub gem will be compatible with rails 3.2?

Hi there is not any part where docs say which version of rails it is compatible with, 3, 4 ?

RubyGems.org doesn't report a license for your gem. This is because it is not specified in the gemspec of your last release.

via e.g.

spec.license = 'MIT'
# or
spec.licenses = ['MIT', 'GPL-2']

Including a license in your gemspec is an easy way for rubygems.org and other tools to check how your gem is licensed. As you can imagine, scanning your repository for a LICENSE file or parsing the README, and then attempting to identify the license or licenses is much more difficult and more error prone. So, even for projects that already specify a license, including a license in your gemspec is a good practice. See, for example, how rubygems.org uses the gemspec to display the rails gem license.

There is even a License Finder gem to help companies/individuals ensure all gems they use meet their licensing needs. This tool depends on license information being available in the gemspec. This is an important enough issue that even Bundler now generates gems with a default 'MIT' license.

I hope you'll consider specifying a license in your gemspec. If not, please just close the issue with a nice message. In either case, I'll follow up. Thanks for your time!

Appendix:

If you need help choosing a license (sorry, I haven't checked your readme or looked for a license file), GitHub has created a license picker tool. Code without a license specified defaults to 'All rights reserved'-- denying others all rights to use of the code.
Here's a list of the license names I've found and their frequencies

p.s. In case you're wondering how I found you and why I made this issue, it's because I'm collecting stats on gems (I was originally looking for download data) and decided to collect license metadata,too, and make issues for gemspecs not specifying a license as a public service :). See the previous link or my blog post about this project for more information.

I'm trying to use the gem but there are too many points which I don't get. I don't understand how should I handle your controllers, how am I supposed to customize message and so on.

I'm a bit lost, I know how can use actionmailer but I feel a bit disoriented on how am I supposed to use this.

Tell me if the project is closed, I can simply close the issue.

Thanks

Hello maktoub-Team!

I have setup maktoub exactly as in the documentation.
I put "gem maktoub" in my Gemfile, "bundle install" it, generated the maktoub:config.

my maktoub.rb looks like this:
http://pastebin.com/gmGNcBXx

i put newsletter_test.html.erb in app/views/maktoub/newsletters/
and then I did this command in the console:

rake maktoub:mail['newsletter_test'] --trace

and this was the output

http://pastebin.com/iW0A7V39