sandstorm / typescript-react-app-kickstart-guide Goto Github PK

currently default props are defined with

export type PickDefaultProps<Props, defaultPropsKeys extends keyof Props> = Readonly<Required<{
    [P in defaultPropsKeys]: Props[P]
  }>>;

and used like

type DefaultProps = PickDefaultProps<ButtonProps, 'state' | "size">;

why not do:

type DefaultProps = Partial<ButtonProps>;

using the built in Partial type?

All the best, Sebastian

Currently this guide covers no solution for routing.

... when react-scripts-ts upgraded to create-react-app 2.x.

Add a CI script to automatically update the gh-pages branch when master is updated.

With CRA 2.0, you need to add TS Loader to storybook; and use jsx=react as parameter.

I can push a full example later :)

create-react-app now supports TypeScript out of the box. No need to use react-scripts-ts.

We can define mapStateToProps more concise as follows:

current:

const mapStateToProps = (dispatch: Dispatch) => ({
  action: (someArg: SomeType) => dispatch(actionCreator(someArg)),
)};

wanted:

const mapStateToProps = {
  action: actionCreator,
};

redux's connect will automatically wrap every actionCreator function with the dispatch. So we end up with the same result with less repetitive code.
reference: https://github.com/reduxjs/react-redux/blob/master/docs/api.md#connectmapstatetoprops-mapdispatchtoprops-mergeprops-options