sangster / gtfs_engine

An engine to drive a RESTful interface for GTFS data

Personal Project Stats

gtfs_engine's Issues

Rails 7 support

Hi! I was trying to bump a project that uses gtfs_engine to Rails 7, but gtfs_engine limits to 6 in the Gemfile and in the gemspec.

gtfs_reader has the same limitation (in regards to ActiveSupport), but I managed to fix it just by bumping (which led me to the limitation here).

When I tried the same bumping strategy on the engine, I got this error:

NameError: uninitialized constant GtfsEngine::Sources::Agency

        agency(&importer.call(Agency, set_id))
                              ^^^^^^
<internal:kernel>:90:in `tap'
/Users/chesterbr/code/chesterbr/cruzalinhas/config/initializers/gtfs_engine.rb:2:in `block in <top (required)>'

The initializer is pretty minimalistic. If I require gtfs_engine/agency on it (as suggested here), the error comes from the next model. By requiring all of them the code works, but ideally this should be fixed on the engine side, so I decided to ask before opening any PRs.

Any ideas?

Rails 5 support

Using latest version of the gem produces error during install.

$ bundle install
 ##Resolving dependencies...
Bundler could not find compatible versions for gem "rails":
  In snapshot (Gemfile.lock):
    rails (= 5.1.2)

  In Gemfile:
    rails (~> 5.1.2)

    gtfs_engine was resolved to 1.2.0, which depends on
      rails (~> 4.1)

ArgumentError: Unknown key: :shared_key

Hello,

I created a brand new project (Rails 4.1.6 / Ruby 2.1.2) and followed the instructions to add the engine. However, after importing and running the migrations, rake gtfs_engine:update (or any rake task, or starting a Rails console or server) fails with the exception below.

I understand the engine extends ActiveRecord with the :shared_key association shortcut, but the exception suggests it is not happening.

Could it be an issue with these Ruby/Rails versions? Some missing require? Any ideas?

Thank you.

ArgumentError: Unknown key: :shared_key. Valid keys are: :class_name, :class, :foreign_key, :validate, :autosave, :table_name, :before_add, :after_add, :before_remove, :after_remove, :extend, :primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of, :counter_cache, :join_table
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/core_ext/hash/keys.rb:71:in `block in assert_valid_keys'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/core_ext/hash/keys.rb:69:in `each_key'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/core_ext/hash/keys.rb:69:in `assert_valid_keys'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations/builder/association.rb:81:in `validate_options'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations/builder/association.rb:61:in `initialize'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations/builder/collection_association.rb:18:in `initialize'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations/builder/association.rb:46:in `new'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations/builder/association.rb:46:in `create_builder'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations/builder/association.rb:35:in `build'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activerecord-4.1.6/lib/active_record/associations.rb:1215:in `has_many'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/app/models/gtfs_engine/calendar.rb:19:in `<class:Calendar>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/app/models/gtfs_engine/calendar.rb:16:in `<module:GtfsEngine>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/app/models/gtfs_engine/calendar.rb:15:in `<top (required)>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:443:in `load'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:443:in `block in load_file'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:633:in `new_constants_in'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:442:in `load_file'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:342:in `require_or_load'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:480:in `load_missing_constant'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:180:in `const_missing'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:512:in `load_missing_constant'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:180:in `const_missing'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/lib/gtfs_engine/sources.rb:59:in `block in add_default_importers'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs-reader-0.2.11/lib/gtfs_reader/bulk_feed_handler.rb:6:in `instance_exec'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs-reader-0.2.11/lib/gtfs_reader/bulk_feed_handler.rb:6:in `initialize'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs-reader-0.2.11/lib/gtfs_reader/config/source.rb:59:in `new'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs-reader-0.2.11/lib/gtfs_reader/config/source.rb:59:in `handlers'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/lib/gtfs_engine/sources.rb:57:in `add_default_importers'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/lib/gtfs_engine/sources.rb:27:in `method_missing'
/Users/chester/code/cruzalinhas/config/initializers/gtfs_engine.rb:2:in `block in <top (required)>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/lib/gtfs_engine.rb:30:in `call'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/gtfs_engine-1.4.0/lib/gtfs_engine.rb:30:in `sources'
/Users/chester/code/cruzalinhas/config/initializers/gtfs_engine.rb:1:in `<top (required)>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:241:in `load'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:241:in `block in load'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:232:in `load_dependency'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:241:in `load'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/engine.rb:648:in `block in load_config_initializer'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/notifications.rb:161:in `instrument'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/engine.rb:647:in `load_config_initializer'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/engine.rb:612:in `block (2 levels) in <class:Engine>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/engine.rb:611:in `each'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/engine.rb:611:in `block in <class:Engine>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/initializable.rb:30:in `instance_exec'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/initializable.rb:30:in `run'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/initializable.rb:55:in `block in run_initializers'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:226:in `block in tsort_each'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:348:in `block (2 levels) in each_strongly_connected_component'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:418:in `block (2 levels) in each_strongly_connected_component_from'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:427:in `each_strongly_connected_component_from'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:417:in `block in each_strongly_connected_component_from'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/initializable.rb:44:in `each'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/initializable.rb:44:in `tsort_each_child'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:411:in `call'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:411:in `each_strongly_connected_component_from'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:347:in `block in each_strongly_connected_component'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:345:in `each'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:345:in `call'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:345:in `each_strongly_connected_component'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:224:in `tsort_each'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:205:in `tsort_each'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/initializable.rb:54:in `run_initializers'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/application.rb:300:in `initialize!'
/Users/chester/code/cruzalinhas/config/environment.rb:5:in `<top (required)>'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:247:in `require'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:247:in `block in require'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:232:in `load_dependency'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.6/lib/active_support/dependencies.rb:247:in `require'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/application.rb:276:in `require_environment!'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/railties-4.1.6/lib/rails/application.rb:389:in `block in run_tasks_blocks'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:240:in `call'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:240:in `block in execute'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:235:in `each'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:235:in `execute'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:201:in `block in invoke_prerequisites'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:199:in `each'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:199:in `invoke_prerequisites'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:178:in `block in invoke_with_call_chain'
/Users/chester/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/task.rb:165:in `invoke'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:150:in `invoke_task'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:106:in `each'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:106:in `block in top_level'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:115:in `run_with_threads'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:100:in `top_level'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:78:in `block in run'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:176:in `standard_exception_handling'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/lib/rake/application.rb:75:in `run'
/Users/chester/.rvm/gems/ruby-2.1.2/gems/rake-10.3.2/bin/rake:33:in `<top (required)>'
/Users/chester/.rvm/gems/ruby-2.1.2/bin/rake:23:in `load'
/Users/chester/.rvm/gems/ruby-2.1.2/bin/rake:23:in `<main>'
/Users/chester/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `eval'
/Users/chester/.rvm/gems/ruby-2.1.2/bin/ruby_executable_hooks:15:in `<main>'