saoudrizwan / dynamicjson Goto Github PK

I used the source code in a playground, and when I want to create a JSON object from a dictionary (it is [String: Any]), it gives me this:

error: Execution was interrupted, reason: EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0).

I used this:

let dictionary: [String: Any] = [
  "name"    : "Omid",
  "age"     : 29,
  "married" : false
]

let dictionaryAsJSON = JSON(dictionary)

print(dictionaryAsJSON.description)

I think it is only in runtime, because Xcode does not show any issue, until running plaground.

The thing you present primarily looks ugly because of the optional chaining at every single step:

if let street = json.person?.address?[0].street.stringValue { }

But it doesn't have to be like that (it is dynamic anyways). I think you could improve that a lot by essentially adding "nil messaging":

if let street = json.person.address[0].street.stringValue { .. }

Instead of returning an optional in every item of the chain, only make the leaf accessors (stringValue, intValue, etc) optional. When a lookup is not successful, return JSON.null (which itself returns JSON.null on all JSON accesses, so that the result propagates).

If you'd like you could also add a JSON.lookupError(parent, key) as a result for missed lookups for debugging purposes (and which also propagates down the call chain, and could even persist the lookup path from the root of the first lookup failure).

Composing a dictionary literal with JSON properties results in those properties being null, instead of decomposing them into dictionaries themselves. For example, when

let foo = ["foo": 3] as JSON
let bar = ["bar": foo] as JSON

bar should equal

[
    "foo": [
        "bar": 3
    ]
] as JSON

However, bar actually equals

[
    "foo": JSON.null
] as JSON

To fix this issue, the JSON.init(_ object: Any) initializer should set self to object when object is an instance of JSON. I'll submit a PR for this later today; let me know what you think!

I hope add a method Codable to JSON, could you help me