GithubHelp home page GithubHelp logo

sap / alert-notification-node-client Goto Github PK

View Code? Open in Web Editor NEW
8.0 8.0 6.0 720 KB

Promise based client library for SAP Alert Notification service for SAP BTP

License: Apache License 2.0

TypeScript 99.58% JavaScript 0.42%

alert-notification-node-client's People

Contributors

alert-notification avatar dependabot[bot] avatar dzhurdzhina avatar feralieva avatar gtnikolov avatar ipaunov avatar mkunev avatar olafschmidt avatar sbabev avatar sebastianwolf-sap avatar valentina-dimitrova avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

sebastianwolf-sap fabianorosa1 isabella232 hitech-gk aweers gregorwolf

alert-notification-node-client's Issues

Support for Cloud-Foundry Destinations

Hi SAP Community,

I added myself some kind of destination support for Cloud Foundry. I am asking myself if I should share it within the community. Maybe I need to spend some more time in it to have it 100% ready to be shared.

As you can guess, this required some changes also in the existing module you did provide (Thx at this point, you're doing a good job) - I am more wondering about if it's recommended to extend (and add a new dependency, only necessary if you wanna use the CF-Destination (@sap/xsenv)) OR if it's more the common way to publish it as a new module and make it available to everyone.

Can you share the recommended best-practice way ?
Thank you in advance,
Regards,
Cedric

Dependency Update

Hello,

I've made a check with npm out what packages need an update. And the list is quite long:

Package                            Current    Wanted   Latest  Location                                       Depended by
@types/jest                        26.0.14   26.0.24  29.5.11  node_modules/@types/jest                       alert-notification-node-client
@types/node                       14.18.63  14.18.63  20.11.2  node_modules/@types/node                       alert-notification-node-client
@typescript-eslint/eslint-plugin     4.4.0    4.33.0   6.19.0  node_modules/@typescript-eslint/eslint-plugin  alert-notification-node-client
@typescript-eslint/parser            4.4.0    4.33.0   6.19.0  node_modules/@typescript-eslint/parser         alert-notification-node-client
axios                               0.26.0    0.26.1    1.6.5  node_modules/axios                             alert-notification-node-client
eslint                              7.10.0    7.32.0   8.56.0  node_modules/eslint                            alert-notification-node-client
eslint-config-prettier              6.12.0    6.15.0    9.1.0  node_modules/eslint-config-prettier            alert-notification-node-client
eslint-plugin-import                2.22.1    2.29.1   2.29.1  node_modules/eslint-plugin-import              alert-notification-node-client
eslint-plugin-prettier               3.1.4     3.4.1    5.1.3  node_modules/eslint-plugin-prettier            alert-notification-node-client
husky                                8.0.1     8.0.3    8.0.3  node_modules/husky                             alert-notification-node-client
jest                                26.4.2    26.6.3   29.7.0  node_modules/jest                              alert-notification-node-client
lint-staged                         10.4.2    10.5.4   15.2.0  node_modules/lint-staged                       alert-notification-node-client
prettier                             2.1.2     2.8.8    3.2.2  node_modules/prettier                          alert-notification-node-client
semver-regex                         3.1.4     3.1.4    4.0.5  node_modules/semver-regex                      alert-notification-node-client
ts-jest                             26.4.1    26.5.6   29.1.1  node_modules/ts-jest                           alert-notification-node-client
tslint                               6.1.1     6.1.3    6.1.3  node_modules/tslint                            alert-notification-node-client
typescript                           3.9.7    3.9.10    5.3.3  node_modules/typescript                        alert-notification-node-client

Would a pull request for this be accepted?

Best Regards
Gregor

Typo in code example of README

Hi,
while using the alert notification example code provided in the README a typo was found: BasicAutentication instead of BasicAuthentication.
I will submit a PR resolving this issue.

Upgrad axios to latest version

Hi,

the version of axios that you are using has a vulnerability which is coming up in our project. Could you please release a new version with the dependency updated?

Best regards,

Christian

Axios Timeout when calling importConfiguration

I have a Cloudfoundry application running on SAP BTP and we want to use @sap_oss/alert-notification-client to send E-Mail Alerts when significant unexpected errors happen.

However when trying to use the package, in order to generate custom events that I have defined in the SAP Alert Notifications Dashboard, I run into an error when calling the importConfiguration function.

I have followed the examples here.

image

The config object shows the correct config object in the data property and also the authorization seems to also work as I have a Bearer token.

I was looking for an option for the request to be able to take more time or maybe I do something else wrong.

This is my code to import the configuration and sending a test event.

image

CORS preflight request returning "403 Forbidden"

Hello all,

I faced with the following problem.

I am trying to execute following code:

const client = new AlertNotificationClient({
      authentication: new OAuthAuthentication({
        username: 'username',
        password: 'password',
        oAuthTokenUrl: 'https://<mydomain>/oauth/token?grant_type=client_credentials'
      }),
      region: new Region(Platform.CF, 'https://clm-sl-ans-canary-ans-service-api.cfapps.sap.hana.ondemand.com'),
    });
    
client.sendEvent(<eventObject>)
  .catch(error => console.log(error));
}

Issue is the following:
POST request triggered CORS preflight which returned 403 error.
image

Is that can be solved on back-end side? I expect that preflight requests shouldn't return 403.

Best Regards,
Andrei Dziamko

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.