sarora / movie_success_eval Goto Github PK

@moahmed @msimar

README.md

It is well written. The data source, questions to solve, methods employed are clearly stated. This might be a personal preference. It would nicer to have a more general description of the background, the motivation of this study right after the title. In Reproducing my Analysis, item 3, maybe you mean plot_data.R, instead of figure_generator.R.

Coding:

1. get_movies.R : it is well documented, simple and clear
2. clean_movies.R : well documented.
3. plot_data.R : well documented. Maybe you have changed the name of the script in the middle. The original name figure_generator.R still appears in the code descriptions. Using ######## to break the whole scripts into segments making codes easier to read. Great trick.
4. movie_dataset_analysis.Rmd : Great presentation, a nice color contrast in graphs.

Doc:

The report presenting data very well and answered the questions proposed in README.md

The following is my personal suggestions to improve the report.

In the graph pairs, in order to give an unbiased comparison, I would suggest having the x-axis on the same scale, for example, both in [0, 325] for the first graph. In this way, we can not only compare the relative weight within a graph but also compare the absolute difference between the two graphs. Since you are comparing earnings, it might be a good idea to have the ratio of revenue to budget ratio being shown.

Summary

This project well satisfies the requirements for milestone #2. Within a limited time, you did a great job. All codes worked as described in my local computer. The reviews of each individual files are listed above and suggestions are provided.

A few more suggestions to make it more attractive to readers (beyond the requirements) :

• Provide your motivations (in layman's terms).
• More detailed writings in your final report, like the questions and the method to answer these questions, the details of your comparisons between latest five years and the five years before, and a conclusion part (take-home message).