Comments (12)
Here you have the feature: https://godoc.org/github.com/savsgio/atreugo#Atreugo.TimeoutPath 😄
Thanks for your contribution.
from atreugo.
I saw that erik merged your PR, when release a new version of fasthttp i will add it in atreugo. ;)
from atreugo.
Hi @losingle,
Do you need ctx.TimeoutErrorWithCode(...)
or TimeoutHandler
??
from atreugo.
You could call to ctx.TimeoutErrorWithCode()
directly, as you would do in native fasthttp, in atreugo handler.
However, TimeoutHandler
is not implemented yet. I will add it soon.
from atreugo.
You could call to
ctx.TimeoutErrorWithCode()
directly, as you would do in native fasthttp, in atreugo handler.However,
TimeoutHandler
is not implemented yet. I will add it soon.
Very much looking forward to this feature.
I can only use first eliminating CTX references in goroutines now
from atreugo.
Here you have the feature: https://godoc.org/github.com/savsgio/atreugo#Atreugo.TimeoutPath 😄
Thanks for your contribution.
How do I change the status code ?
eg. valyala/fasthttp@38473d3
from atreugo.
TimeoutPath
always return 408 if timeout is reached like fasthttp in https://godoc.org/github.com/valyala/fasthttp#TimeoutHandler
If you want to set a custom status code in response, use https://godoc.org/github.com/savsgio/atreugo#RequestCtx or ctx.SetStatusCode(<yourStatusCode>)
from atreugo.
I think you are supervising the timeout manually, right? with channels, selects, context or something similar.
if it's truth, not use PathTimeout
or ctx.TimeoutErrorWithCode(...)
, just finish the handler and return the response with your own status code
from atreugo.
well, as if only timeout manually
thank you
from atreugo.
So, why do you need to change the status code when timeout?
I see your PR valyala/fasthttp#589 in fasthttp.
I think so, it's not recommended to return another status code if timeout
from atreugo.
Yes, normally, there is no need to change the status code, following the rules of HTTP.
However, some business scenarios may be needed, and I think fasthttp, as a network base library, should give control to the developers.
Because our business will need to timeout the request, return 204 status code
from atreugo.
I've just release a new version v8.1.0 with TimeoutWithCodePath
support :)
from atreugo.
Related Issues (20)
- Possible breaking change in patch version? "path must begin with '/' in path ''" HOT 2
- AttachContext overrides previous AttachContext HOT 2
- Hi, Savsgio, how to add CORS middleware? HOT 30
- Is it possible to run "after" middleware even when "before" middleware exits error? HOT 5
- Unable to match URL with "/" ending HOT 1
- Unsupported path parameters with root / prefix HOT 1
- Problem with trailing "/" when optional url param is empty (11 version) - 308 redirect HOT 3
- I can not install HOT 1
- Error! installing with go get github.com/savsgio/atreugo HOT 5
- Cannot update/download deps HOT 1
- any sort of html template kind of real life example code to go with? router with html hello world at least HOT 1
- Instrumenting servers / paths to add metrics doesn't work when view returns an error HOT 1
- Use atreugo and autocert HOT 2
- Support custom logger HOT 4
- Possible race condition in context propagation HOT 3
- rate limit middleware request HOT 3
- Race condition when calling RequestCtx.Value() HOT 4
- Sentry APM Middleware HOT 1
- Occasional panic HOT 1
- Configurable JSON Marshaller HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atreugo.