GithubHelp home page GithubHelp logo

Comments (8)

imxxiv avatar imxxiv commented on July 19, 2024 1

I understand the meaning of this example.
Thanks.

from atreugo.

savsgio avatar savsgio commented on July 19, 2024

I prefer to keep router and server configuration be managed by atreugo (configuration struct) and not directly by users, for avoid errors or crashes. Atreugo was born to avoid that and make it simple.

I'm maintaining atreugo and some official packages of fasthttp (router, session and websocket), so I trying to keep aline the atreugo configuration with their configuration.

You could see that if there is any update (fasthttp, router, etc), I have immediately updated it.

But, if you need some extra configuration about router or fasthttp, please let me know or make a PR.
I will have the pleasure for review or merge it 😄

from atreugo.

savsgio avatar savsgio commented on July 19, 2024

@imxxiv Thanks for your advise!

from atreugo.

imxxiv avatar imxxiv commented on July 19, 2024

Atreugo wants to make web development easier, so developers don't have to pay too much attention to servers and routers.
I understand your thoughts.
You contributed a lot of code in the server, router, session, websocket project, thank you very much for your contribution, we lazy developers can be lazy.
However, this is also my concern. Once the atreugo update is slow or paused, developers using atreugo will be limited to atreugo. If atreugo can be integrated into server and router, this situation will not be greatly affected.

Of course, this is just my suggestion, I support your decision.

from atreugo.

imxxiv avatar imxxiv commented on July 19, 2024

If atreugo is the upper software of sever and router, you will be tired because you need a lot of synchronization adaptation.
If atreugo is the glue software for server and router, you will be more relaxed, because some developers can do it themselves.

My idea is that I hope that atreugo can go further.

from atreugo.

savsgio avatar savsgio commented on July 19, 2024

By now, i will think about it, but i don't promise you that i will change it.

It's a hard change and it could be break all, because atreugo use a specific version of fasthttp and router, if their api change, it's very probably that atreugo will crash, so it's very unsafe.

But, probably i could add two functions that returns the pointer of router and server to just configure it under your own responsability.

from atreugo.

savsgio avatar savsgio commented on July 19, 2024

For example:

s := server.ServerPtr()
s.Name = "myOverrideServerName"
s.Concurrency = 100

r := server.RouterPtr()
r.RedirectTrailingSlash = false
r.HandleOPTIONS = false

from atreugo.

savsgio avatar savsgio commented on July 19, 2024

However, don't worry about slow or paused updated, because now i'm very active in Atreugo (and other projects) and fasthttp. 😄

If it changes, i will let you know.

from atreugo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.