Comments (10)
Why do you need lock that?
The processing without cache is quite expensive (and long) in my case. So if I receive 10 requests with the same URI then I should not run the processing 10 times, I should run it just once and just return the same result to all 10 requests.
If finally you will use fasthttp directly with router, I recommend you to use https://github.com/fasthttp/router instead fasthttprouter, because fasthttp team maintain this router (including me, who belong to the team).
OK. I will. Thank you :)
from atreugo.
A proposal: #38
from atreugo.
One more problem.
I need for After
be always executed if a Before
filter decides so. I suppose this is the reason why other frameworks wraps handlers in middlewares instead of making Before
and After
:)
from atreugo.
For me not actual, anymore. I decided to do not use atreugo
. Too difficult to implement a caching middleware here :(
from atreugo.
Sorry, I have been bussy last days, I will review your PR, and merge it
from atreugo.
But why are you going to not use atreugo?
I think you shouldn't have too much difficults to use it.
You could share a bit of code with me and I could try to help you.
from atreugo.
Because you need to execute the before and after middlewares without execute the view, right?
Is the view response save on cache?
from atreugo.
I will review your PR, and merge it
The PR breaks current API, so it is very understandable if you will decide not to merge it :)
Because you need to execute the before and after middlewares without execute the view, right?
I've switched to fasthttprouter
. Here's the result (a working middleware):
c.NextHandler(ctx)
executes a view. I cannot make the same on atreugo
due to two problems:
- I cannot prevent the execution of the view, like in line 77. My PR solves this problem.
- I cannot make a lock like in line 66. My PR doesn't solve this problem.
from atreugo.
- I will think some methods to encourage that.
- Why do you need lock that?
from atreugo.
If finally you will use fasthttp directly with router, I recommend you to use https://github.com/fasthttp/router instead fasthttprouter, because fasthttp team maintain this router (including me, who belong to the team).
The router has some enhancements and improve performances with respect original package
from atreugo.
Related Issues (20)
- Possible breaking change in patch version? "path must begin with '/' in path ''" HOT 2
- AttachContext overrides previous AttachContext HOT 2
- Hi, Savsgio, how to add CORS middleware? HOT 30
- Is it possible to run "after" middleware even when "before" middleware exits error? HOT 5
- Unable to match URL with "/" ending HOT 1
- Unsupported path parameters with root / prefix HOT 1
- Problem with trailing "/" when optional url param is empty (11 version) - 308 redirect HOT 3
- I can not install HOT 1
- Error! installing with go get github.com/savsgio/atreugo HOT 5
- Cannot update/download deps HOT 1
- any sort of html template kind of real life example code to go with? router with html hello world at least HOT 1
- Instrumenting servers / paths to add metrics doesn't work when view returns an error HOT 1
- Use atreugo and autocert HOT 2
- Support custom logger HOT 4
- Possible race condition in context propagation HOT 3
- rate limit middleware request HOT 3
- Race condition when calling RequestCtx.Value() HOT 4
- Sentry APM Middleware HOT 1
- Occasional panic HOT 1
- Configurable JSON Marshaller HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atreugo.