sbstjn / cra-pipeline Goto Github PK

Hi,
Thanks for publishing this. I just noticed that an error doc is in the pipeline.ts here:

This results in a 404 page for the error.html page when a non-existent URL is accessed like: http://pipeline-files8e6940b8-tyzn4y41xz9l.s3-website-us-east-1.amazonaws.com/non-existant.html

When hosting an SPA the error document should be set to index.html so that the JS can show a 404 (and maybe report an error to the crash logger)

If you would like to ensure node 14 is available you specify the image in the PipelineProject:

          project: new CodeBuild.PipelineProject(this, "BuildWebsite", {
            projectName: "XXX",
            buildSpec: CodeBuild.BuildSpec.fromSourceFilename(
              "./infra/buildspec.yml"
            ),
          + environment: {
          +     buildImage: CodeBuild.LinuxBuildImage.STANDARD_5_0,
          + },
          }),

After initial install and configuration, I encounter this error:

Do you wish to deploy these changes (y/n)? y Pipeline: deploying... Pipeline: creating CloudFormation changeset... 10:11:42 PM | CREATE_FAILED | AWS::KMS::Key | PipelineArtifactsB...ryptionKey01D58D69 The new key policy will not allow you to update the key policy in the future. (Service: Kms, Status Code: 400, Request ID: b 652e882-829a-4b8c-b4db-825b433f9053, Extended Request ID: null)

I'll research to try and resolve.

Chris