GithubHelp home page GithubHelp logo

Fails on bootstrap variables about sc5-styleguide HOT 7 CLOSED

sc5 avatar sc5 commented on August 17, 2024
Fails on bootstrap variables

from sc5-styleguide.

Comments (7)

varya avatar varya commented on August 17, 2024

Hi @Janpot! Thanks for report, we are investigating how to fix this. Before this happens, you might be interested in how to exclude bootstrap (or other vendor styles) from the building process. If so, please check this paragraph https://github.com/SC5/sc5-styleguide#how-to-exclude-styles-from-source

from sc5-styleguide.

Janpot avatar Janpot commented on August 17, 2024

My bootstrap files are out of my build folder, I just copied the variables file to create my own theme, then noticed it doesn't build. FYI I added some failing tests to gonzales-pe yesterday about this issue tonyganch/gonzales-pe#42

from sc5-styleguide.

varya avatar varya commented on August 17, 2024

Did not noticed that you reported to Gonzales already and reported again :-)
I fixed first issue with this PR tonyganch/gonzales-pe#45 Let's wait them to merge.
The second one also looks doable, I am fixing it right now.

from sc5-styleguide.

Janpot avatar Janpot commented on August 17, 2024

Ok, thanks. Just want to let you know the test case you presented there didn't fail for me when I tried it. It seems to only fail when it's on a function call. cheers.

from sc5-styleguide.

varya avatar varya commented on August 17, 2024

@Janpot In this case Gonzales test system understands that this is about arguments of functions and not about standalone braces. You can see this from other test cases related to arguments there: https://github.com/tonyganch/gonzales-pe/tree/dev/test/sass/arguments Their test system wraps these cases as "arguments" itself.

from sc5-styleguide.

varya avatar varya commented on August 17, 2024

Second issue is covered in PR tonyganch/gonzales-pe#46

from sc5-styleguide.

Janpot avatar Janpot commented on August 17, 2024

Awesome!

from sc5-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.