GithubHelp home page GithubHelp logo

Comments (10)

jpbackman avatar jpbackman commented on July 18, 2024

@adam-beck which version of sc5-styleguide are you using? We released 0.3.2 today, which addresses the socket connection issue (port is ignored). The root cause is in [email protected]: socketio/socket.io-client#802

from sc5-styleguide.

adam-beck avatar adam-beck commented on July 18, 2024

I was using a previous version.

from sc5-styleguide.

jpbackman avatar jpbackman commented on July 18, 2024

The solution introduced in 0.3.2 is not perfect, as it assumes that users are connecting directly to the designated Express server port. Problems start when ports are forwarded.

from sc5-styleguide.

andreipopovici avatar andreipopovici commented on July 18, 2024

+1
Also having issues with forwarded ports.

from sc5-styleguide.

jpbackman avatar jpbackman commented on July 18, 2024

@andreipopovici we released 0.3.3 yesterday with a downgraded version of socket-io (1.2.1) which resolves socket endpoint port correctly. 0.3.4 is the latest sc5-styleguide version (minor cli argument bug fixed), please update.

from sc5-styleguide.

andreipopovici avatar andreipopovici commented on July 18, 2024

Trying it as we speak :) Will update with progress.

from sc5-styleguide.

jpbackman avatar jpbackman commented on July 18, 2024

0.3.4 works, we're running our demo site inside a Docker container, which forwards the internal port 3000 to something random like 49317 on the host machine, which again is mapped to 80 in nginx or apache.

http://demo.styleguide.sc5.io/

from sc5-styleguide.

andreipopovici avatar andreipopovici commented on July 18, 2024

Socket.io seems to work fine after the update. Thanks!

Heads-up: a small typo in the Gulp instructions (the comma after this line):

var sass = require('gulp-sass'),

from sc5-styleguide.

jpbackman avatar jpbackman commented on July 18, 2024

@andreipopovici no problem, and thanks, well spotted. Fixed it already, though. :)

from sc5-styleguide.

andreipopovici avatar andreipopovici commented on July 18, 2024

You need to slow down before these Internet wires catch fire :P

from sc5-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.