GithubHelp home page GithubHelp logo

Comments (6)

cyberixae avatar cyberixae commented on August 17, 2024

I was able to reproduce this. After adding a two parameter mixin some tests fail and hang.

from sc5-styleguide.

cyberixae avatar cyberixae commented on August 17, 2024

Preventing the tests from hanging is not trivial. The tests hang because the styleguide itself never finishes running. We currently run the styleguide in the before phase of Mocha tests and the before phase does not support timeouts. Therefore if we wish to prevent the tests from hanging we would need to create a promise in the before phase and resolve the promise as a part of executing the first actual test.

from sc5-styleguide.

cyberixae avatar cyberixae commented on August 17, 2024

I have tracked the reason of style guide hanging down to the gonzales.srcToAST call in kss-splitter.js The call never returns and therefore causes style guide to hang. We need to find out whether or not upgrading Gonzales will fix this problem.

from sc5-styleguide.

cyberixae avatar cyberixae commented on August 17, 2024

The problem can be reproduced by adding the following less notation to test/projects/less-project/source/styles/style.less Not sure what kind of chapter numbering would be good for language specific tests. Of course while we are at it we could also add multi-parameter mixin tests for other style languages.

// Section with multiparameter less mixin
//
// Markup:
// <div class="mixin-call">Section markup</div>
//
// Styleguide 5.0

.border-mixin(@width; @color) {
  border: @width solid @color;
}

.mixin-call {
  .border-mixin(1px; @color-blue);
}

from sc5-styleguide.

cyberixae avatar cyberixae commented on August 17, 2024

Upgrading Gonzales did not seem to fix the problem.

from sc5-styleguide.

cognivator avatar cognivator commented on August 17, 2024

+1
We are a mixin-heavy LESS shop. Loving the tool, save for this issue, and a couple others (issue #546, issue #510)

from sc5-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.