GithubHelp home page GithubHelp logo

Comments (12)

jpbackman avatar jpbackman commented on July 18, 2024

Thanks for reporting, we'll take a look and figure out the best way to handle this. At least the markup/visual representation should definitely use the actual color, whereas in the designer tool the $main-font-color value should still be $dark-grey.

from sc5-styleguide.

sarahquigley avatar sarahquigley commented on July 18, 2024

Thanks for your prompt reply! Yes, the markup / visual representation is the issue. I would agree that designer tool value should stay $dark-grey. Looking forward to your fix on this one - thanks so much again!

from sc5-styleguide.

ctumolosus avatar ctumolosus commented on July 18, 2024

+1

from sc5-styleguide.

ivnmaksimovic avatar ivnmaksimovic commented on July 18, 2024

+1

from sc5-styleguide.

cognivator avatar cognivator commented on July 18, 2024

+1
Although I must admit, I have chained LESS variables that are working properly, somehow.
The following definitions resolve to the value of the right-hand vars,

@mi-color-product-productname1: @mi-color-corp-green2;
@mi-color-product-productname2: @mi-color-corp-blue;
@mi-color-product-productname3: @mi-color-corp-plum;
@mi-color-product-productname4: @mi-color-corp-yellow;

Wondering if I'm just getting lucky with the way the variables are sorted prior to replacement in the Angular filter, 'setVariables'...?

BTW: Making the LESS variables work requires the fix proposed in issue #546.

from sc5-styleguide.

i-have-no-name avatar i-have-no-name commented on July 18, 2024

+1

from sc5-styleguide.

Jaswetz avatar Jaswetz commented on July 18, 2024

+1

from sc5-styleguide.

criz avatar criz commented on July 18, 2024

+1

from sc5-styleguide.

ayjee avatar ayjee commented on July 18, 2024

I am using LESS Variables as well and only some of my variables are chaining correctly while others are not. I have used KSS previously and am familiar with the syntax so not sure what else could be wrong.

@cognivator was there anything you did in specific to get this working for your less variables?

from sc5-styleguide.

danmv avatar danmv commented on July 18, 2024

Has anyone here added bootstrap-sass to the SC5 styleguide and use its components to document them.

from sc5-styleguide.

shanecarmody avatar shanecarmody commented on July 18, 2024

Iā€™m pretty sure this is related to #782 as well.

from sc5-styleguide.

terotil avatar terotil commented on July 18, 2024

After some poking I can tell that versions below 0.3.36 seem to have various problems with multiple dashes, hyphens and variable name length. For 0.3.36 at least problems with multiple hyphens and defined variable name being shorter than the one in the definition seem to be resolved.

Anybody still seeing this with 1.x?

from sc5-styleguide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.