scalar-labs / cassy Goto Github PK

Describe the bug
The cluster-wide restoration process restores only cluster-wide snapshots, it does not restore the incremental backup created with cluster-wide snapshot id.

To Reproduce
Steps to reproduce the behavior:

1. Create scalar-terraform environment (network, cassandra with cassy, scalardl resources)
2. Insert some values using kelpie.
3. Port-forward Cassy port to access Cassy from your local

$ ssh -F ssh.cfg -L 20051:localhost:20051 cassy-1.internal.scalar-labs.com

4. Register cluster using cassy command

$ grpcurl -plaintext -d '{"cassandra_host": "<cassandra node 1 ip>"}' localhost:20051 rpc.Cassy.RegisterCluster

5. Create a cluster-wide backup using Cassy backup creation command.

$ grpcurl -plaintext -d '{"cluster_id": "CLUSTER-ID", "backup_type": 1}' localhost:20051 rpc.Cassy.TakeBackup 

6. Insert some more values using kelpie or manually
7. Execute nodetool flush in each Cassandra node.
8. Create an incremental backup with previously created cluster-wide snapshot id

$ grpcurl -plaintext -d '{"cluster_id": "CLUSTER-ID", "snapshot_id": "SNAPSHOT-ID", "backup_type": 3}' localhost:20051 rpc.Cassy.TakeBackup

9. Stop and clear each cassandra nodes
10. Restore the incremental backup to all Cassandra nodes.

$ grpcurl -plaintext -d '{"snapshot_id": "SNAPSHOT-ID", "restore_type": 1, "cluster_id": "CLUSTER-ID"}' localhost:20051 rpc.Cassy.RestoreBackup

Expected behavior
Restore snapshot with incremental backup files to all nodes

Actual behavior
Snapshots are properly restored.
Incremental backup files are not restored.

Environment Details
Test environment: Azure
Cassy version: 1.2.0

Additional Details
Restore is working fine while we execute cluster-wide restore with the incremental backup restore.

$ grpcurl -plaintext -d '{"snapshot_id": "SNAPSHOT-ID", "restore_type": 1, "cluster_id": "CLUSTER-ID"}' localhost:20051 rpc.Cassy.RestoreBackup
$ grpcurl -plaintext -d '{"snapshot_id": "SNAPSHOT-ID", "restore_type": 2, "cluster_id": "CLUSTER-ID"}' localhost:20051 rpc.Cassy.RestoreBackup