Invalid source specified error about mr_tinypng

[ogrosko]

Hi I made little investigation

In method \Scarbous\MrTinypng\Service\TinypngService->shrinkImage() I'm receiving images but all types. So it crashes when in my case image /typo3conf/ext/bb_boilerplate/Resources/Public/Images/wsw_neu_rgb.svg comes for shrinking

So I thnik there is also necessary check mime-type of image like in \Scarbous\MrTinypng\SignalSlots\FileProcessingService->preFileProcess

Temporary I fix this bug as follow:

public function shrinkImage($source, $target = NULL) { if (!in_array(mime_content_type($source), array('image/jpeg', 'image/png'))) return; //...

[saphrus]

Hi ogrosko,

this issue was fixed in 0.3.1
Are you sure you are using the latest version?

[ogrosko]

@saphrus
Yes I'm using latest version from typo3-ter

"typo3-ter/mr-tinypng" : "0.3.1",

[saphrus]

Hi ogrosko,

as far as i can see your system is trying so send an svg, what should actually not be possible, since mr_tinypng checks wether your file is a png or a jpeg before it is sent to the tinify-api. I will have a look into this on next tuesday (after easter weekend ;)).

[Scarbous]

Hi ogrosko,
the problem with unsupported mime types was fixed at Version 0.3.1.
Which TYPO3 and PHP version has your installation?

[ogrosko]

Hmm wierd
I am using typo3 v7.6.4 and php v5.6

Is the correct version in typo3 ter?

[ogrosko]

Using the latest version v0.3.3 from dev-master I'm still getting same error.
Would be also possible to use composer versioning e.g. git tagging, or update latest typo3-ter version?

[Scarbous]

Thank you @ogrosko.
I will add it to the extension.
In a future Version I need this because it will shrink Images from CSS, so I have to check the mime-type.

[ogrosko]

@Scarbous
Your fix is wrong. please change it from

if (!in_array(mime_content_type($source), array('image/jpeg', 'image/png'))) {
to
if (in_array(mime_content_type($source), array('image/jpeg', 'image/png'))) {

also you uses 'image/jpeg' and 'image/png' on multiple places. Use it as const or public property etc.

[ogrosko]

👍

[ogrosko]

Can you also update extension in TYPO3 TER?