scarbous / mr_tinypng Goto Github PK

In BE module reduction bytes format are not so user friendly.
You use custom viewHelper for bytes formating with following labels
'labels' => array(' ', ' Ki', ' Mi', ' Gi', ' Ti', ' Pi', ' Ei', ' Zi', ' Yi')

and it's not so user friendly, I thing

You can use buildin viewHelper

You save: <b>{reduction -> f:Format.Bytes()}</b>

which is much more better. imho ;)

If the API limit is reached, an exception is thrown. This is not so nice on a productive website. Instead the images should be delivered without being shrinked. Perhaps only logging an error would be better.

Hey
Did you make some performance changes? I have noticed page load time changes.

Page load without mr_tinypng ext. 3-4s
Page load with mr_tinypng ext 5-6s (All images on page already compressed)

I think approx. 2 seconds are huge impact on page load
I use latest version from git dev-master

Thanks

There is JS error in BE module

Uncaught Error: Bootstrap's JavaScript requires jQuery(anonymous function) Uncaught TypeError: jQuery is not a function

Try to use
TYPO3.jQuery

or include own jquery

Hi
First of all great extension! I'm using tinypng but I was looking for something automatic for typo3

But sometimes I get following error:

Invalid source specified (HTTP 400/JSON validation error)

I have to refresh page and than it works. But with caching no, so after error occur whould be great to clear caches.

It looks like it trys to compress unsupported image format (in this case svg). Or am I wrong?

I tried mr_tinypng and it worked great, except for the page were the ke_search-module is located.
Following (shortened) output appears:

Invalid source specified (HTTP 400/JSON validation error) 
32 Tinify\Exception::create("Invalid source specified", "JSON validation error", 400)
31 Tinify\Client::request("post", "https://api.tinify.com/shrink", "{"error":"JSON validation error","message":"Invalid source specified"}")
...
28 Scarbous\MrTinypng\Service\TinypngService::shrinkImage("/home/www/typo3/typo3conf/ext/ke_search/res/img/attention.gif", "/home/www/typo3/typo3temp/attention.gif1592229915gif")
...

So the image of ke_search is the problem. Is it the format gif? Is it because it's an image of an extension?