schedjoules / android-public-calendars-sdk Goto Github PK

FAILURE: Build failed with an exception.

* Where:
Build file '/home/jitpack/build/Demo/build.gradle' line: 1

* What went wrong:
A problem occurred evaluating project ':Demo'.
> Failed to apply plugin [id 'com.android.application']
   > Minimum supported Gradle version is 3.3. Current version is 3.1. If using the gradle wrapper, try editing the distributionUrl in /home/jitpack/build/gradle/wrapper/gradle-wrapper.properties to gradle-3.3-all.zip

I guess it would help to put the gradle/wrapper directory under version control.

Review and update any permission handling in the SDK and in the Demo app given that they both target Lollipop which requires runtime permission handling.

See this comment in particular:
#6 (comment)

"..requires the app to request permissions at runtime, otherwise calendar synchronization won't work.

In an earlier commit we added an intro. The design, wording and imagery of the intro need to be finalized.

Apparently, the net.opacapp.multilinecollapsingtoolbar.CollapsingToolbarLayout library removed in #8 is actually used in a layout and now it causes runtime crash. (Not sure why build succeeds without it)
So it has to be put back and need to solve the related proguard issue.

The code doesn't comply with our code style.

@rutgerg commented on Mon Oct 23 2017

This small UI bug (almost unnoticable) is a result of the theme update in #18 , it can be fixed in this separate ticket.

Hi!

I cannot compile and install the project. I already tried to add a few missing "export=true/false" attributes to the AndroidManifest.xml files but I still get this error:

org.dmfs.syncadapter.TriggerSyncActivity: Targeting S+ (version 31 and above) requires that an explicit value for android:exported be defined when intent filters are present'

The problem seems to be that the AndroidManifest.xml file in

org.dmfs:calendarcontent:1.9

needs to be updated to include an "export=true/false" line for the activity because the activity has an intent-filter. Unfortunately that library is only available as a compiled file, not as source. Can you please provide an updated version that fixes this problem?

UI glitch as a result of #18, will be fixed with this ticket.

Must migrate to Target SDK 31 (at least). Otherwise, the SDK cannot be used.

Here's one error, but more may appear:

Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE 
be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE 
if some functionality depends on the PendingIntent being mutable, 
e.g. if it needs to be used with inline replies or bubbles.

@dmfs commented on Tue Sep 19 2017

When enabling the sync switch for the first time but declining the permissions the switch should be turned off again.

Use key "sid"

The loading of the events for a calendar often hangs, showing the loading indicator forever without loading the list.

Not sure what this depends on, it happens more often when I navigate to the list quickly. Reinstalling the app usually helps.

On Android 23+ the GET_ACCOUNTS permission should not be necessary anymore. Starting with Android 23 this permission is only required to read accounts of other apps. Own accounts can always be read.

An open source option is http://www.helpstack.io/

Not necessary after unique_tournament refactor

Steps:
Install app, go to a calendar page, enable sync. Permission grant dialogs appear, grant them.
After that settings icon doesn't appear as it would be expected. (Only if user navigates away and back or disables, enables sync)

The public calendar SDK still uses a mix of Holo and Material design elements. In order to have a modern look, as a user I want it to use the same theme as the event discovery SDK.