schedjoules / swift-api-client Goto Github PK

When trying to subscribe to that calendar there is a crash caused by the sdk not being able to Decode the JSON response. The crash log on Xcode is:

Fatal error: 'try!' expression unexpectedly raised an error: Swift.DecodingError.keyNotFound(PageKeys(stringValue: "subscriptionId", intValue: nil), Swift.DecodingError.Context(codingPath: [], debugDescription: "No value associated with key PageKeys(stringValue: "subscriptionId", intValue: nil) ("subscriptionId").", underlyingError: nil)): file /Users/edhoru/Documents/GitHub/ios-public-calendars-sdk/Pods/SchedJoulesApiClient/ApiClient/Source/Subscriptions/Queries/SubscriptionStatusQuery.swift, line 48
2019-07-19 05:32:30.716145-0500 iOS-SDK[1634:627354] Fatal error: 'try!' expression unexpectedly raised an error: Swift.DecodingError.keyNotFound(PageKeys(stringValue: "subscriptionId", intValue: nil), Swift.DecodingError.Context(codingPath: [], debugDescription: "No value associated with key PageKeys(stringValue: "subscriptionId", intValue: nil) ("subscriptionId").", underlyingError: nil)): file /Users/edhoru/Documents/GitHub/ios-public-calendars-sdk/Pods/SchedJoulesApiClient/ApiClient/Source/Subscriptions/Queries/SubscriptionStatusQuery.swift, line 48

This error is the cause of

https://app.zenhub.com/workspaces/all-57ff999f6d2146cd57ad306f/issues/schedjoules/ios-public-calendar-apps/10

The ApiClientTests needs to be added to the compile sources for the Tests target.

Both the Country and Language models have the same fields except for icon. Because icon is an optional anyways, it would make more sense to have a uniform Locale class represent both Country and Language.

Based on clients compatibility reduce the requirement to 11.0 to make it easier for clients to use.

During my last review I accidentally let a few non-final classes slip through. They should be fixed to be final.

Things of interest so far:

• App Events
• Widgets
• Swift Package Manager

The weather calendar doesn't follow the same logic as the other calendars, since the it uses the units defined in the client end, we have to add the method so clients don't make the request directly to our backend.

Version 1.7.5 of cocoa pods doesn't support swit 3, so we need to update the Result cocoa pod

Immutability is a desirable property for every type. In order for a class to be immutable it has to be final.
Make sure there are non non-final classes and no public fields or properties which can be modified.

The item_id is nil for Page responses returned from a search query, so this property should be an optional Int both for the Page and PageItem protocols.

The Protocols directory inside Pages should be moved inside the Models directory as those are protocols corresponding to the Page models.

Swift does not support using protocols directly, so we have to return a concrete type as the query Result to be able to use it in the generic settings view controller.

We got a review on schedjoules app that says: Why is the app not available in German? You can set it, but is it still English? Functions, buttons etc

Please check

User reported that there is a crash when opening a calendar in Event.swift line 47

Tapping Restore purchases in the settings view controller is crashing due to a nil apiclient

It looks like Swift SDK is not supporting iPad. Check via the link below the video for (a part of) the issues

https://www.dropbox.com/s/begpjnhwjsgf85v/191114%20iCalendar%20iPad%20Screen%20Recording.mov?dl=0

The current Query implementations contain a lot of duplicated code. In particular almost all their properties have the same values and their handleResult methods are all the same.

The design should be improved by introducing an abstract DelegatingQuery which delegates all properties and the handleResult to a delegate passed to the ctor.
In addition introduce a PageQuery which only takes the parameters and an optional path suffix which is then used to simplify all the existing page implementations.

Proposed usage of DelegatingQuery and PageQuery is like so:

public final class NextPageQuery: DelegatingQuery {

   public convenience init(numberOfItems: Int) {
       super.init(queryItems: [URLQueryItem(name: "next", value: String(numberOfItems))])
   }

   /// Initialize with the number of items to return, locale
   public convenience init(numberOfItems: Int, locale: String) {
       super.init(queryItems: [URLQueryItem(name: "next", value: String(numberOfItems)),
                              URLQueryItem(name: "locale", value: locale)])   
}

Also see https://medium.com/design-patterns-in-swift/design-patterns-in-swift-decorator-pattern-2026e7112869 for more info on this topic.

Queries which have all their properties pre-defined do not require an init method. However, to be able to initialize them in another module, an empty public initializer must be declared explicitly. This signals to the compiler that the class was meant to be used as public.

Xcode generated comments on top of every file include the filename. After renaming a file, these comments still contain the original name.

This should be the job of the SchedJoulesApi class.

The Pages protocols need to be updated to reflect optional fields in the API response, this is especially important when it comes to searching, as there are much less fields returned from a search query than a normal page query.

We need to add a uuid value for the "u" key in the url: https://schedjoules.slack.com/archives/C880NL13Q/p1568236148080700

When subscribing to a weather calendar, if you select imperial units instead of metric the resulting calendar still displays metric values.

In order to show a calendar preview, as a partner I need a Query to fetch calendar data.

The Query should return high level event objects.