schorfes / grunt-lintspaces

A Grunt task for checking spaces in files.

Hey! 👨‍💻

grunt-lintspaces's Issues

ignores 'css-comments'

Show number of checked files

Show at the end of executed task the number of checked files.

Is there a way to ignore whole files and directories?

E.x. node_modules

Make destructive changes

Instead of just warning. Why not fix things at the same time? I understand not everything can do this, but for something like newlines at the end of files it shouldn't be a problem.

Possible to change severity so grunt job is not aborted?

Is it possible to somehow set an option so the grunt job is not aborted when trailing whitespaces are found, but a warning is still produced, so I know that is the case?

New option to guess indentation

Try to guess the correct indentation using the following rules:

The indentation of the current line is correct when:

• the amount of indentations is equal to the previous or
• the amount of indentations is one less than the previous line or
• the amount of indentations is one more than the previous line

The option should be set to false by default.
The output of this option should not end in a failed validation

Add junit output

Tries to read directories

The task tries to validate directories which results in the following error:
Warning: Unable to read "tests/files/comments" file (Error code: EISDIR).

Indentation detection not working well in html.erb files

I’ve setup lintspaces with the following:

lintspaces: {
            html: {
                src: [
                    '**/*.html.erb'
                ],
                options: {
                    newline: true,
                    trailingspaces: true,
                    indentation: 'spaces',
                    spaces: 2
                }
            },
        }
}

but when I run it, it does not detect any problems even though all my html.erb files are indented with 4 spaces instead of 2. I’m guessing that’s because 2 is a mulltiple of 4? Any way around that?

The newline detection does work though...

Not only detect but also fix indentation problems

What do you think of this feature?

Lints spaces in comments, bug or feature?

First of all, great plugin; but it also lints (and fails) comment blocks such as this style of Laravel comments:

/*
 |---------------------------------------------------------------------
 | Comment text
 |---------------------------------------------------------------------
*/

And more of a documentation style syntax:

/**
 * Function name...
 * Description.....
 */

Are there any plans to ignore comment blocks in the future?

newlineMaximum failing

I get this error: "Maximum amount of newlines exceeded. Found 2 newlines, expected maximum is 3"

I want accept this kind of situation:

function pee(arg) {
  //
}


function poo(arg) {
  //
}

This works only when I set the newlineMaximum to 5 or higher.

Test for useless empty lines at the beginning of a file

Add an extra option for useless empty lines at the beginning of a file.

Simple multiline JS comments failing

This style of comment seems to be ignored when using ignores: ['js-comments'].

/*
I'm a comment and I cause issues!
*/

I've added to the JS comments tests and I'll take a look at fixing it, but in the mean time, does anyone have any comments (a pun I didn't intend!) on adding this?

https://github.com/adrianblynch/grunt-lintspaces/blob/master/tests/files/comments/comments.js

Bump Junitwriter to 0.4.0

# Run  npm install [email protected]  to resolve 2 vulnerabilities
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ merge                                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ junitwriter                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ junitwriter > merge                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/722                       │
└───────────────┴──────────────────────────────────────────────────────────────┘


┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ junitwriter                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ junitwriter > xmlbuilder > lodash                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/577                       │
└───────────────┴──────────────────────────────────────────────────────────────┘

when running npm audit from master

Test for a maximum amount of newlines between code blocks

Add an extra option for a maximum amount of newlines between code blocks.

Is it possible to ignore markdown syntax in the comments?

Fetch options info from .editorconfig

Does not showCodes / showTypes beyond first file.

With the following config:

all: {
        src: [
            'Gruntfile.js',
            'grunt/**/*.js',
            'build-config/**/*.js',
            'webapp/**/*.js',
            '!webapp/vendor/**/*.js',
            'tests/**/*.js'
        ],

        options: {
            ignores: [
                'js-comments'
            ],
            showTypes: true,
            showCodes: true,
            editorconfig: '.editorconfig'
        }
    }

I get a number of errors, but the errors are only shown for the first file:

☓ webapp/module1/views/add.js
  L3: (warning) Expected an indentation at 4 instead of at 2. [INDENTATION_SPACES_AMOUNT]
  L4: (warning) Expected an indentation at 4 instead of at 2. [INDENTATION_SPACES_AMOUNT]
  L5: (warning) Expected an indentation at 4 instead of at 2. [INDENTATION_SPACES_AMOUNT]
  L33: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L34: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L36: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L37: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L38: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L40: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L41: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L42: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
  L43: (warning) Expected an indentation at 24 instead of at 22. [INDENTATION_SPACES_AMOUNT]
  L44: (warning) Expected an indentation at 20 instead of at 18. [INDENTATION_SPACES_AMOUNT]
☓ webapp/module1/views/edit.js
☓ webapp/module1/views/table.js
☓ webapp/module2/view.js
☓ webapp/module2/views/editing-app.js
☓ webapp/module3/app.js
☓ webapp/module3/views/filterCollectionView.js
...

Confusion between ignore `js-comments` and `newlineMaximum`

When i use

options: {
  ignore: [
    "js-comments"
  ],
  newlineMaximum: 1
}

the ignored comments are counted as new lines. And i get an newlineMaximum error.

What can i do?

Not an issue

... but I just wanna say: As a white space nazi I very very much appreciate this package!
👍

Thank you

Linting is very slow

Hey there,

I've been using this plugin in all my projects and never had issues until now.
I don't know why yet but it now takes almost a minute to lint 6 files:

Running "lintspaces:all" (lintspaces) task
Verifying property lintspaces.all exists in config...OK
Files: 1.0.0/js/module-1.js, 1.0.0/less/module-mixins.less, 1.0.0/less/settings.less, 1.0.0/html/footer.html, 1.0.0/html/header.html, 1.0.0/html/source.html
Options: showCodes=false, showTypes=false, showValid=false, editorconfig="../.editorconfig", ignores=["js-comments","c-comments","java-comments","as-comments","xml-comments","html-comments","python-comments","ruby-comments","applescript-comments"]
>> 6 lint free.

Each of those files don't have more than 35 lines of code in them.

• 1.0.0/js/module-1.js [32 lines]
• 1.0.0/less/module-mixins.less [35 lines]
• 1.0.0/less/settings.less [11 lines]
• 1.0.0/html/footer.html [3 lines]
• 1.0.0/html/header.html [9 lines]
• 1.0.0/html/source.html [1 line]

No minified code either so lines never exceed more than 160 characters per line (as per our style-guide)
...

And this is the .editorconfig

# editorconfig.org
root = true

[*]
indent_style = tab
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = false

[*.md]
trim_trailing_whitespace = false

Any idea?

problem with spaces

I use options in a grunt task:

less: {
src: [
'css/less/*/'
],
options: {
indentation: 'spaces',
spaces: 2
}
}

If I have 3 spaces it validate that indentation spaces are wrong,
If I have 4 it pass and it shouldn't