scrtlabs / salad Goto Github PK
View Code? Open in Web Editor NEWA coinjoin implementation for the Enigma Discovery network
salad's Issues
Dockerfile Nightly Version of Rust Doesn't Have Clippy
When running the Dockerfile manually, I run into the following error on this line:
Step 8/13 : RUN rustup override set nightly-2019-07-04
---> Running in 8d8f71b6b684
info: syncing channel updates for 'nightly-2019-07-04-x86_64-unknown-linux-gnu'
info: latest update on 2019-07-04, rust version 1.37.0-nightly (088b98730 2019-07-03)
error: component 'clippy' for target 'x86_64-unknown-linux-gnu' is unavailable for download for channel nightly-2019-07-04
The command '/bin/sh -c rustup override set nightly-2019-07-04' returned a non-zero code: 1
My fix for it was to update the Nightly Date to:
RUN rustup override set nightly-2019-11-04
It installs clippy now. For reference, following link shows missing packages from nightly installs:
https://rust-lang.github.io/rustup-components-history/index.html
I can submit a PR to your Dockerfile, but wanted to share this first with you.
dApp having issues connecting to Salad Server
Also reported by @stan_yi on dev forum here: https://forum.enigma.co/t/browser-stucked-at-connecting-to-the-salad-server/1212/2
I'm not sure yet if the issue is due to his environment: exposing the right ports for his configuration or if it's related to the develop discovery images.
In my case it happens after I submit a deal transaction, then change the current MetaMask account and reload the browser (trying to simulate sending from different accounts).
If I just switch MetaMask accounts and reload the browser, without submitting any deals, it's able to connect to the Salad Server successfully each time.
If I launch 3 different browsers (Brave, Chrome and Safari) each set to a different MetaMask account, I'm able to submit deals, reload and the dApp and it connects to the Salad Server.
I've tried resettin MetaMask accounts too, but that didn't help.
Snapshot of browser dev tools info attached.
To resolve the issue I stop the dApp and restart the process:
yarn clean-run-operator- (another terminal)
cd frontend yarn start
If I launch the dApp and don't change the sender address, I'm able to submit the req'd 3 deals and see the deal execution and funds distributed to the recipient addresses.
Discovery integration tests failing on "yarn start"
This issue originated in the dev forum here: https://forum.enigma.co/t/salad-some-integration-tests-fail/1243
Summary:
Doing a fresh git clone of the salad repo and following the README instructions up to and including yarn start, some of the integration tests fail.
Pull was done from the develop branch. Configuration used: yarn configure-sw.
Env:
MacOS Catalina 10.15.1
Node: v11.15.0
rustc 1.38.0-nightly (8a58268b5 2019-07-31)
yarn: 1.19.2
docker: Docker version 19.03.5, build 633a0ea
docker-compose: docker-compose version 1.24.1, build 4667896b
Troubleshooting:
Used this info to remove all docker images, including orphaned and dangling and re-tried the README steps: https://getintodevops.com/blog/keeping-the-whale-happy-how-to-clean-up-after-docker
The integration test failures were reproduced consistently.
Details:
- Six (6) out of the 14 integration tests fail with errors
Init tests › should check that 1 worker(s) and the principal node, and only them, are registered
client_1 |
client_1 | expect(received).toEqual(expected) // deep equality
client_1 |
client_1 | - Expected
client_1 | + Received
client_1 |
client_1 | @@ -1,7 +1,7 @@
client_1 | Array [
client_1 | - 2,
client_1 | + 0,
client_1 | 0,
client_1 | 0,
client_1 | 0,
client_1 | 0,
client_1 | 0,
Init tests › should deposit tokens in worker banks
client_1 |
client_1 | Failed: "Returned error: VM Exception while processing transaction: revert Unregistered worker"
Init tests › should login the worker(s)
client_1 |
client_1 | : Timeout - Async callback was not invoked within the 20000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 20000ms timeout specified by jest.setTimeout.Error
Init tests › should check that 1 worker(s), and only them, are logged in
client_1 |
client_1 | expect(received).toEqual(expected) // deep equality
client_1 |
client_1 | - Expected
client_1 | + Received
client_1 |
client_1 | @@ -1,7 +1,7 @@
client_1 | Array [
client_1 | - 1,
client_1 | + 0,
client_1 | 0,
client_1 | 0,
client_1 | 0,
client_1 | 0,
client_1 | 0,
Init tests › should get the worker parameters for the current block
client_1 |
client_1 | expect(received).toEqual(expected) // deep equality
client_1 |
client_1 | - Expected
client_1 | + Received
client_1 |
client_1 | - Array [
client_1 | - "0x0000000000000000000000000000000000000000",
client_1 | - ]
client_1 | + Array []
Init tests › should create getTaskEncryptionKey from core (with call to P2P)
client_1 |
client_1 | : Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.Error:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.