sdomi / amiwm Goto Github PK

hi there,
i notice that windows when user clicks on maximize gadget, the calculated size isn't taking into account the height of the menubar,
thus maximized windows bottom decorations aren't shown properly, they are partialy rendered offscreen. half of the bottom decorations (resize gadget and bottom window border) aren't reachable.

edit: this was already corrected in marcus latest in trunk updates, just need to import and merge

Some dropdowns in programs such as Firefox doesn't show up. In firefox, it's most of dropdowns but bookmarks and dropdowns from standard menu bar

run executecmd,
type "xterm" in the input field
click "cancel" button.

result: xterm is being executed despite "cancel" button was clicked instead of "ok" button.

edit: sorry about that, this bug was introduced by my own mistakes working on the code. please ignore.

hello,I found a bug of null-deref in source code of amiwm,would you help me check if this bug is true?thanks for your patience and effort.

step 1 :
In file amiwm/libami/module.c , function md_command line 153 :
Store null to buffer

step 2 :
In file amiwm/libami/module.c , function md_command line 149 :
Program reaches the return point, modifying the value *(buffer) to null

step 3 :
In file amiwm/libami/kbdsupport.c , function md_grabkey line 14 :
Function md_command modifies the value ptr to null, where &(ptr) is used as the 5th parameter (buffer)

step 4 :
In file amiwm/libami/kbdsupport.c , function md_grabkey line 15 :
Load value from ptr

step 5 :
In file amiwm/libami/kbdsupport.c , function md_grabkey line 15 :
Load value from ptr and assign to res

hello,I found a bug of unchecked return value to null pointer dereference in source code of amiwm,would you help me check if this bug is true?thanks for your patience and effort.

step 1 :
In file amiwm/libami/module.c , function md_command line 170 :
Store the allocated memory to buffer (lacking failure check, 15 out of 21 memory allocations checked failures)

step 2 :
In file amiwm/libami/module.c , function md_command line 149 :
Program reaches the return point, modifying the value *(buffer) to null

step 3 :
In file amiwm/libami/mdicon.c , function md_create_appicon line 23 :
Function md_command modifies the value data to null, where &(data) is used as the 5th parameter (buffer)

step 4 :
In file amiwm/libami/mdicon.c , function md_create_appicon line 32 :
Copy data from data (data can be null)

Hello, I was redirected by Marcus to contact you here.

I was trying to package it for Arch Linux, which is missing it, but unfortunately due to missing DESTDIR support, this is not trivial.
Are there any plans to provide a PKGBUILD or support DESTDIR?

I have created a preliminary PKGBUILD file, for the original package, but I saw that you are improving it. Supporting DESTDIR is the first step.

What are your thoughts about it?

in erikarn's fork, there's 3 or 4 additional icons provided, i thought it was a good idea and wanted to submit a few more to bundle with amiwm. the idea is to work step by step toward a more functional desktop.
of course it's a long way off at the moment, and amiwm would also require some substantial improvement, code-wise. anyway, here is some magicwb icons to cover the usual the apps being ran on desktops: browser, mailer, filer, editor, .. and so on.

i think icons should get a dedicated directory, and also be copied during the make install to /usr/local/lib/amiwm/icons/. they should also be added in the default system.amiwmrc as a base sample config. if this is acceptable i will try and provide a PR with the modified system.amiwmrc that will make use of them.

also i wanted to say amiwm needs an icon viewer. i think it should be possible to isolate the part of the existing code that allow us to display amiga icons, and make a standalone 'icon viewer' out of it.

[ icons.zip ]

Gets annoying when using my tp in bed, with no lights in the room ON, may be possible to fix.

hello,I found a bug of file descriptor leak in source code of amiwm,would you help me check if this bug is true?thanks for your patience and effort.

step 1 :
In file amiwm/libami/iconlib.c , function int_load_do line 377 :
Function fopen executes and stores the return value to f

step 2 :
In file amiwm/libami/iconlib.c , function int_load_do line 377 :
Select the true branch at this point (f!=null is true)

step 3 :
In file amiwm/libami/iconlib.c , function int_load_do line 378 :
Select the true branch at this point (1==fread(buf[0],78,1,f) is true)

step 4 :
In file amiwm/libami/iconlib.c , function int_load_do line 378 :
Select the true branch at this point (diskobj!=null is true)

step 5 :
In file amiwm/libami/iconlib.c , function int_load_do line 381 :
Select the true branch at this point (diskobj->do_Magic!=58128 is true) but did not close it

here's an example case.
worker app, when first launched assume my desktop is bigger than what it currently really is (800x600).
so what happens is this:

if i click on the middle gadget on the top right size of the window, the app shrink to lowest size. it's not iconify, but the app's window borders (including resize gadget on the bottom) is now completely accessible. so i can resize the window like this:

so all good, right ? no, not so fast. if i click again on that middle gadget on that top right corner of the window, then i get back at the state displayed in first screenshot, and impossible to access the resize gadget again.
so it's half working. it's possible to workaround about that problem a bit, but it's still there.
idealy we either want to honor the classic trick on linux: alt+click-drag a window from any part of it, until we can move it around enough so that we can access that resize gadget. that, or force amiwm to constrain apps to max desktop resolution (minus amiwm menubar, and minus the window borders) but that may create problems with some apps eventualy. i think the classical alt-click-drag trick all the other linux desktop do might be better.

cloned repo, untar'd and switched to directory
ran
./configure
sudo make install
log and error below

the error:
make: *** No rule to make target 'libami/libami.a', needed by 'amiwm'. Stop.

the log:
m
log.txt

running arch linux latest (amd64)

hello,I found a bug of null-deref in source code of amiwm,would you help me check if this bug is true?thanks for your patience and effort.

step 1 :
In file amiwm/libami/module.c , function md_command line 153 :
Store null to buffer

step 2 :
In file amiwm/libami/module.c , function md_command line 149 :
Program reaches the return point, modifying the value *(buffer) to null

step 3 :
In file amiwm/libami/mdicon.c , function md_create_appicon line 23 :
Function md_command modifies the value data to null, where &(data) is used as the 5th parameter (buffer)

step 4 :
In file amiwm/libami/mdicon.c , function md_create_appicon line 32 :
Copy data from data (data can be null)

hello,I found two bugs of null-deref in source code of amiwm,would you help me check if this bug is true?thanks for your patience and effort.

step 1:
In file amiwm/build/executecmd.c , function refresh_str_text line 179:
Load value from XExtentsOfFontSet(dri)->max_logical_extent.width （function XExtentsOfFontSet is defined in libx11-6）

step2:
In file libx11-6/src/FSWrap.c, function XExtentsOfFontSet, line 252:
return null to caller.so return value from function XExtentsOfFontSet may be a null pointer,and it is derefered in step 1 without check.

====================================================================================
step 1:
In file amiwm/build/executecmd.c , function strkey , line 326:
Load value from XExtentsOfFontSet(dri)->max_logical_extent.width （function XExtentsOfFontSet is defined in libx11-6）

step2:
In file libx11-6/src/FSWrap.c, function XExtentsOfFontSet, line 252:
return null to caller.so return value from function XExtentsOfFontSet may be a null pointer,and it is derefered in step 1 without check.

On multi-monitor setups, some dropdown menus may appear on the first screen instead of the second; This problem mainly happens with firefox.

When a window that is supposed to be fullscreen appears, it just has a regular window border. Such problem happens on almost all applications; Only a few Valve games on hl2 engine work OK

I really enjoying amiwm. It just needs some more work I guess.

sdl1.2 and smfl apps are fine but sdl2 and unity apps crash on startup:

Pioneer:
X Error of failed request: BadMatch (invalid parameter attributes)
Major opcode of failed request: 42 (X_SetInputFocus)
Serial number of failed request: 220
Current serial number in output stream: 221

Grafx-sdl2 version:
X Error of failed request: BadMatch (invalid parameter attributes)
Major opcode of failed request: 42 (X_SetInputFocus)
Serial number of failed request: 214
Current serial number in output stream: 215

unity game:
X Error of failed request: BadMatch (invalid parameter attributes)
Major opcode of failed request: 42 (X_SetInputFocus)
Serial number of failed request: 220
Current serial number in output stream: 229

smfl had this issue before but fixed it:
SFML/SFML#991

I opened a bug report on the sdl page:
https://bugzilla.libsdl.org/show_bug.cgi?id=5427

I also found this:
https://stackoverflow.com/questions/16720961/many-xsetinputfocuss-and-xsync-causes-error

I hope you can fix this on the wm side, that would be cool 👍