GithubHelp home page GithubHelp logo

Comments (4)

k15z avatar k15z commented on May 10, 2024 3

The discriminator uses the PacGAN framework to prevent mode collapse with pack size 10. @csala The docstring can be updated to clarify this restriction, the batch size must be divisible by the pack_size.

from ctgan.

Baukebrenninkmeijer avatar Baukebrenninkmeijer commented on May 10, 2024

In my tests, batch size needs to be a multiple of 10. I don't recall why this issue was again specifically.

from ctgan.

elisim avatar elisim commented on May 10, 2024

In addition, batch_size option should be moved to fit function instead of in the CTGANSynthesizer ctor.
Now:

ctgan = CTGANSynthesizer(batch_size=128)

How it should be (IMHO):

ctgan.fit(data, discrete_columns, epochs=3, batch_size=128)

from ctgan.

csala avatar csala commented on May 10, 2024

The discriminator uses the PacGAN framework to prevent mode collapse with pack size 10. @csala The docstring can be updated to clarify this restriction, the batch size must be divisible by the pack_size.

Thanks @k15z, I opened an issue on SDV to add this to the CTGAN model documentation, so I'm closing this one for now.

In addition, batch_size option should be moved to fit function instead of in the CTGANSynthesizer ctor.
Now:

ctgan = CTGANSynthesizer(batch_size=128)

How it should be (IMHO):

ctgan.fit(data, discrete_columns, epochs=3, batch_size=128)

Thanks for the suggestion @elisim, but this was discussed a long time ago and we decided to move in another direction, so we will try to keep the hyperparameter organization as it is right now.

Also, bear in mind that we are pushing it even further when using CTGAN from SDV, where all the hyperparameters and setup arguments are passed when the model is created and the only input argument for the fit method is the data to which the model is fitted.

from ctgan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.