Ridiculous number of compiler warnings building on a modern Linux system about openseachest

[joekhoobyar]

gcc version 9.2.0, everywhere I've compiled it (including a cross-compiler).

On my amd64 boxes:

$ gcc -v -c
Using built-in specs.
COLLECT_GCC=gcc
Target: x86_64-pc-linux-gnu
Configured with: /var/tmp/portage/sys-devel/gcc-9.2.0-r2/work/gcc-9.2.0/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/9.2.0 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/9.2.0 --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/9.2.0/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/9.2.0/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/include/g++-v9 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/9.2.0/python --enable-languages=c,c++ --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --disable-nls --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened 9.2.0-r2 p3' --enable-esp --enable-libstdcxx-time --disable-libstdcxx-pch --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-altivec --disable-fixed-point --enable-targets=all --enable-libgomp --disable-libmudflap --disable-libssp --disable-systemtap --enable-vtable-verify --disable-libquadmath --enable-lto --without-isl --enable-default-pie --enable-default-ssp
Thread model: posix
gcc version 9.2.0 (Gentoo Hardened 9.2.0-r2 p3) 

On my 32-bit arm boxes:

$ gcc -v -c
Using built-in specs.
COLLECT_GCC=gcc
Target: armv7l-unknown-linux-gnueabihf
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://github.com/archlinuxarm/PKGBUILDs/issues --enable-languages=c,c++,fortran,go,lto,objc,obj-c++,d --enable-shared --enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --disable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --host=armv7l-unknown-linux-gnueabihf --build=armv7l-unknown-linux-gnueabihf --with-arch=armv7-a --with-float=hard --with-fpu=vfpv3-d16 gdc_include_dir=/usr/include/dlang/gdc
Thread model: posix
gcc version 9.2.0 (GCC) 

And my cross-compiler for arm:

$ arm-hardfloat-linux-gnueabihf-gcc -v -c
Using built-in specs.
COLLECT_GCC=arm-hardfloat-linux-gnueabihf-gcc
Target: arm-hardfloat-linux-gnueabihf
Configured with: /var/tmp/portage/cross-arm-hardfloat-linux-gnueabihf/gcc-9.2.0-r2/work/gcc-9.2.0/configure --host=x86_64-pc-linux-gnu --target=arm-hardfloat-linux-gnueabihf --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/arm-hardfloat-linux-gnueabihf/gcc-bin/9.2.0 --includedir=/usr/lib/gcc/arm-hardfloat-linux-gnueabihf/9.2.0/include --datadir=/usr/share/gcc-data/arm-hardfloat-linux-gnueabihf/9.2.0 --mandir=/usr/share/gcc-data/arm-hardfloat-linux-gnueabihf/9.2.0/man --infodir=/usr/share/gcc-data/arm-hardfloat-linux-gnueabihf/9.2.0/info --with-gxx-include-dir=/usr/lib/gcc/arm-hardfloat-linux-gnueabihf/9.2.0/include/g++-v9 --with-python-dir=/share/gcc-data/arm-hardfloat-linux-gnueabihf/9.2.0/python --enable-languages=c,c++ --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --disable-nls --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened 9.2.0-r2 p3' --enable-esp --enable-libstdcxx-time --disable-libstdcxx-pch --enable-poison-system-directories --with-sysroot=/usr/arm-hardfloat-linux-gnueabihf --disable-bootstrap --enable-__cxa_atexit --enable-clocale=gnu --disable-multilib --disable-altivec --disable-fixed-point --with-float=hard --enable-libgomp --disable-libmudflap --disable-libssp --disable-systemtap --enable-vtable-verify --disable-libquadmath --enable-lto --without-isl --enable-default-pie --enable-default-ssp
Thread model: posix
gcc version 9.2.0 (Gentoo Hardened 9.2.0-r2 p3) 

[xahmad]

Can you post your gcc/clang version?

BTW, some of them are just laziness on our part, which should definitely be fixed, but others are challenge of being able to write code that works in Windows/Linux/FreeBSD and all the different compliers & compiler versions that are supported in each of these OSes.

[joekhoobyar]

I also opened #34 to fix missing MAKEFLAG on sub-make invocations.

[vonericsen]

Thanks for reporting this @joekhoobyar
I'm set up a newer system with GCC 9 and can see the large number of warnings.
It looks like some of these were introduced in GCC9. I will figure out how to clean these up.
I have been using GCC 7.4.0 which is why I haven't seen many of them before.

I'll also take a look at #34 today as well.

[vonericsen]

Hi @joekhoobyar,
I've pushed some changes to fix some of the warnings.
A majority of them are a warning for possible unaligned addresses when accessing packed/aligned structures.
I fixed most of those on the opensea-transport branch "Warning_Packed_Fixes", but I need to do more testing before I finish that branch and before I fix the remaining warnings that are still present.

[joekhoobyar]

That's awesome @vonericsen - this will really help increase confidence in cross-compiled builds. I am planning on getting a 32-bit arm version ready for a dependent project: openebs

[vonericsen]

Hi @joekhoobyar,

I have finished cleaning up all the warnings I could find in GCC9. I also ran clang and fixed a few more that were found by clang as well.
All of the changes are pushed on develop now.
The only warning that I see remaining is from clang related to some #pragma message output we use to help understand which NVMe include file is being used in Linux.
If you find others, please let us know! We do our best to keep free of warnings, but occasionally miss some.