GithubHelp home page GithubHelp logo

Comments (8)

vonericsen avatar vonericsen commented on July 19, 2024 2

I added a new action that will create a Source_With_Submodules.tar.xz and Source_With_Submodules.zip when we push release tags.

It seems that the default for a release uses git archive which does not traverse submodules. I read up on this issue (multiple git repos on Github have similar issues filed) and it seems git-archive-all is the best solution to use, so this new Github action will use that to publish these at the releases going forward.

from openseachest.

thesamesam avatar thesamesam commented on July 19, 2024 1

Thank you!

from openseachest.

faithanalog avatar faithanalog commented on July 19, 2024 1

I see the new tarball in the alpha release https://github.com/Seagate/openSeaChest/releases/tag/v23.02-alpha.1, and it looks to build just fine for me. I think it is a little weird that the folder extracts to Source_With_Submodules. and I'd maybe prefer it extract to openSeaChest-23.02-alpha.1 to match the release version. But that's just stylistic, it doesn't really matter. Thanks for adding this, it'll save me a lot of trouble!

from openseachest.

vonericsen avatar vonericsen commented on July 19, 2024 1

@faithanalog I will investigate changing that to the version you mentioned. I think that would make a lot more sense.

from openseachest.

xahmad avatar xahmad commented on July 19, 2024

We are working on a 18.10 release which will be finished before the end of this month and it should have all the FreeBSD fixes.

from openseachest.

asomers avatar asomers commented on July 19, 2024

The problem with the release tarballs isn't FreeBSD-specific; they simply don't include all of the code. The tarballs, as opposed to the git checkout, don't build anywhere.

from openseachest.

thesamesam avatar thesamesam commented on July 19, 2024

ping

from openseachest.

vonericsen avatar vonericsen commented on July 19, 2024

This has been fixed in https://github.com/Seagate/openSeaChest/releases/tag/v23.03
I even got the subfolder to have a nice name like @faithanalog mentioned previously! 😄

If you have any trouble, please feel free to reopen this issue and I will look at this again.

from openseachest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.