seatgeek / businesstime

A simple python utility for calculating business time aware timedeltas between two datetimes

businesstime

BusinessTime is a simple utility for calculating business time aware timedeltas between two datetimes. BusinessTime's understanding of weekends, holidays and business hours can be easily configured in code.

>>> datetime(2013, 12, 26, 5) - datetime(2013, 12, 23, 12)
datetime.timedelta(2, 61200)
>>> bt = businesstime.BusinessTime(holidays=businesstime.holidays.usa.USFederalHolidays())
>>> bt.businesstimedelta(datetime(2013, 12, 23, 12), datetime(2013, 12, 26, 5))
datetime.timedelta(1, 18000)

Features

• Simple, pythonic, business-time-aware datetime math
• A simple declarative format for defining holidays
• A number of useful iterators/predicate functions related to holidays/weekends/business hours

businesstime's Issues

Bad calculation

start = datetime(2015,2,23,hour=16, minute=0)
end = datetime(2015,2,24,hour=14, minute=20)
bt = BusinessTime(weekends=(SAT, SUN), holidays=holidays, \
            business_hours=(time(7), time(16)))
        business_time = bt.businesstimedelta(start, end)

Output is 7:20:00

start = datetime(2015,2,23,hour=16, minute=1)

Output is 0:00:00

Tested on Python 3.4.0

Function for add deltatime

Could you make Function for add deltatime?

See
https://github.com/ogt/workdays
https://bitbucket.org/bgelineau/python-bizdatetime

one case not working

import businesstime

bt = businesstime.BusinessTime((time(9), time(18)), (5, 6), holidays=None)
t = bt.businesstimedelta(datetime.now(), datetime.now() + timedelta(days=1, hours=-4))
#t = bt.businesstimedelta(datetime.now() - timedelta(days=1), datetime.now() + timedelta(days=0, hours=0))
t = bt.businesstimedelta(datetime.now() - timedelta(hours=2), datetime.now() + timedelta(days=1, hours=0))
m = (float(t.days) * 9 * 60 + float(t.seconds) / 60)
h = m / 60

print h

Not working well if the two times are after business with one day of difference. It should return one business day.

USFederalHolidays doesn't handle holidays that fall on the weekend but are observed on Friday/Monday

From opm.gov:

Federal law (5 U.S.C. 6103) establishes the following public holidays for Federal employees. Please note that most Federal employees work on a Monday through Friday schedule. For these employees, when a holiday falls on a nonworkday -- Saturday or Sunday -- the holiday usually is observed on Monday (if the holiday falls on Sunday) or Friday (if the holiday falls on Saturday).

Holiday generator misses previous holidays

When isholiday is called, the holiday generator is invoked. But the holiday generator maintains a cache, and it assumes that future calls to isholiday will be in the future (while len(self._holidays) == 0 or dt > self._holidays[-1]). However, my code iterates backward and breaks this, because the generator is "forward-only".

Timedelta to businesshours support

First of all, thank you very much for your work on this library.

I found myself slightly confused when trying to extract business hours from the timedelta result.

>>> d1 = datetime.datetime(2017, 5, 23, 9, 0)
>>> d2 = datetime.datetime(2017, 5, 24, 9, 0)
>>> r = BusinessTime().businesstimedelta(d1, d2)
datetime.timedelta(1)

My immediate thought to extract the business hours (which in this case it's 8) was to call
timedelta.total_seconds() method on the result, but this will return the equivalent of 24 hours in seconds, not 8 hours - given it has no knowledge of the business_hours in the BusinessTime object.

This experience proved a bit confusing and was wondering if you might be able to suggest a solution to this? Would a PR would be accepted for this sort of functionality?

Time delta calculation bug when both start and end times are after hours

This piece of code returns the wrong time delta:

>>> bt=BusinessTime()
>>> bt.businesstimedelta(datetime(2016, 6, 17, 18), datetime(2016, 6, 20, 18))
datetime.timedelta(0)

The start time is after hours on a Friday at 6pm, while the end time is after hours on the following Monday at 6pm. The correct answer should be datetime.timedelta(1), right?

setup.py/pip does not install holidays

pip install businesstime and python setup.py install does not install the holidays submodule.

First instant of business day not considered part of that day

For example:

>>> bt.businesstimedelta(datetime(2014, 1, 28, 9), datetime(2014, 1, 29, 9))
datetime.timedelta(0, 28800)

Expected output is datetime.timedelta(1)

The Leap-years has not been in mind

Hi, i think could be a problem in the Lead-years

https://github.com/seatgeek/businesstime/blob/master/businesstime/holidays/__init__.py#L9

Code breaks with TZ aware datetimes

Everything breaks with tz-aware datetimes. It would be good to take an optional tzinfo and to cast the datetimes into that TZ automatically.

Support calculating negative timedeltas

More flexible specification for business hours

Currently you can only specify a pair of open and close times which apply on non-weekend, non-holiday days. It'd be useful to have open and close times which vary by day of the week, time of the year, etc.

Also, the concept of weekend days is fairly arbitrary. It probably makes sense to take this extension of the concept of flexible business hours to support days with no business hours, and have that replace the concept of weekends.