sebastian-c / spectroscopy Goto Github PK

This package needs a treeplot function. This will make a rectangular grid where the size of each rectangle is the presence of each soil colour. tmplot from the treemap package will likely be of use.

Brendan suggested the following:

In Filzmoser (2004) it is detailed a method to scale outlier critical value based on sample size. It is suggested we implement this into the remove_mahalanobis_outliers function, perhaps adding the default option for the critical value to be "auto".

Brendan wrote some code to convert from spectra to rgb/munsell. There are some good ideas in it such as allowing customisation of the RGB limits.

Brendan Malone wrote a copy of soil_colour_spectra which should be integrated.

Features worth integrating include:

• Modifiable RGB cutoffs

Functions are bareboned at the moment and need examples.

Some functions use .spectra and others use spectra. Make this consistent.

This would help with the examples mentioned in #7 and help with testing.

Given that functions are likely to be modified and arguments added, using Hadley's testthat package would allow better catching of bugs.

Testthat was integrated in cfb881a. It remains to add tests for all functions.

Sometimes (usually only on first load of a package) a pdf device opens and nothing is plotted. At the moment, not reproducible, but the issue is now logged.