sebastienrousseau / dotfiles Goto Github PK

Describe the bug
This issue is reported here
Please fix this

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS
• Browser
• Version

Smartphone (please complete the following information):

• Device
• OS
• Browser
• Version

Additional context
Add any other context about the problem here.

https://github.com/reedia/dotfiles/blob/b38b0dee7c548f2cec7f239d5b76f3c07ff233cc/src/dotfiles/zsh/functions.zsh#L25-L25

This is related to use of tree.

tree is installed as part of homebrew/brew-package.sh, however there is a function in .bash_profile that essentially overrides this.

I propose one of the following options, please let me you thoughts / objections.

1. remove the tree function in bash profile
2. if you want to keep it rename it to treee or btree
3. wrap the bash function in a check to see if /usr/local/bin/tree exists and either dont load the bash version or load it with a different name.
4. leave as is

https://github.com/reedia/dotfiles/blob/df55f22613d668719665ed509e47ddd5a414e480/src/dotfiles/zsh/.zshrc#L40-L40

After looking into managing java versions, there seems to be two options that make the most sense (to me)
See https://stackoverflow.com/questions/26252591/mac-os-x-and-multiple-java-versions

Have a look and let me know what you think

1) ENV Vars for each with a default (quite clean)

export JAVA_10_HOME=$(/usr/libexec/java_home -v10)
export JAVA_8_HOME=$(/usr/libexec/java_home -v1.8)
export JAVA_9_HOME=$(/usr/libexec/java_home -v9)

alias java10='export JAVA_HOME=$JAVA_10_HOME'
alias java8='export JAVA_HOME=$JAVA_8_HOME'
alias java9='export JAVA_HOME=$JAVA_9_HOME'

#default java
export JAVA_HOME=$JAVA_10_HOME

Can easily change using the alias'd comands

2) jenv (installed via brew)

This is a fairly comprehensive tool for managing java versions on your machine

Setup jenv (added to .bash_profile)

if which jenv > /dev/null; then 
    eval "$(jenv init -)"
    export PATH="$HOME/.jenv/shims:$PATH"
fi

Then get list of installed java versions

/usr/libexec/java_home -V

Add each one to jenv

jenv add /path/from/above/command

you can then set then check and set the java versions Globally, locally or per folder etc

https://github.com/reedia/dotfiles/blob/b38b0dee7c548f2cec7f239d5b76f3c07ff233cc/src/dotfiles/zsh/functions.zsh#L42-L42