secmask / go-redisproto Goto Github PK

Currently a superficial the parser cannot read messages larger than 65kb, an artificial limit imposed in these lines: https://github.com/secmask/go-redisproto/blob/master/parser.go#L20.

However, the Redis protocol specifies that strings might be up to 512MB. The redis-rb driver, for example, works with strings even larger than 512MB. Furthermore, there are plans to even remove this limit from the server (see redis/redis#757).

However, go-redisproto currently returns an "Invalid bulk size" error. Is there any reason for this limitation?

The repo doesn't contain a license file and the license isn't listed in the README. Is it Apache V2 , MIT, public domain, or ?

The following path can never be executed:

...since when doing writer.WriteBulks(nil), the bulks variable ends up being a [][]uint8{[]uint8(nil)}, which is not equal to nil.

The same holds true for WriteObjects as well. On the other hand, doing WriteBulkStrings(nil) does produce a nil array ([]byte{'*', '-', '1', '\r', '\n'}).