GithubHelp home page GithubHelp logo

serempy's People

Contributors

aadm avatar fredpreveltrace avatar leandrofgr avatar seismicreservoirmodeling avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

serempy's Issues

minor code review

GeostatisticsDiscreteDriver.py : yields an error at line 45, because the parameter l (correlation range) is int, while function IndicatorKriging checks it is a float (line 127). The authors should check for int or float

GeostatisticsDiscreteDriver.py: figure 4, subplot 1: the title should be "Indicator Kriging Probability for facies 0". Without it the user might think it is the probability of facies 1 because the higher values are yellow, just like yellow is the color for facies 1.

GeostatisticsDiscreteDriver.py: figure 4, subplot 2: the title should be "Indicator Kriging most likely facies"

RockPhysicsInversionDriver.py: there should be titles in each figure to help the user understand what method is being used

SeismicInversionDriver.py: lines 82 and 83: substitute the function np.matlib.repmat with np.tile. At least my numpy version did not have this function (maybe it is deprecated), while np.tile worked.

ESSeisInversionDriver.py: there should be titles on the figures 2 and 3 to help the user understand what he is looking at (prior realizations and posterior, respectively)

ESPetroInversionDriver.py: include legend in the figures to help understand what is being plotted.

EnsembleSmootherMDA data pertubation step

Line 39 in the script "Inversion.py" there is the following mathematical expression:

np.sqrt(alpha * sigmaerr)

This is not usual mathematical operation for matrices (numpy.sqrt takes the element-wise square root of the matrix), and maybe what you want to use here is the function numpy.linalg.cholesky:

np.linalg.cholesky(alpha * sigmaerr)

Cheers

Great code btw

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.