selkamand / gg1d Goto Github PK

df <- structure(list(testcol = c("02", "02", "02", "02", 
                                      "02", "02", "02", "02", "02", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", "06", 
                                      "06", "08", "12", "12", "12", "12", "12", "12", "12", "12", "12", 
                                      "12", "12", "12", "12", "12", "12", "12", "12", "12", "12", "12", 
                                      "12", "12", "12", "12", "12", "12", "12", "12", "12", "12", "12", 
                                      "12", "12", "12", "12", "12", "12", "12", "12", "12", "12", "12", 
                                      "12", "12", "14", "14", "14", "14", "14", "14", "14", "14", "14", 
                                      "14", "14", "14", "14", "14", "14", "14", "14", "14", "14", "14", 
                                      "14", "14", "14", "14", "14", "14", "14", "14", "14", "14", "14", 
                                      "14", "14", "14", "14", "14", "14", "14", "14", "15", "15", "16")), row.names = c(NA, 
                                                                                                                  -223L), class = c("tbl_df", "tbl", "data.frame"))

gg1d_plot(df, cols_to_plot = "testcol")
#> Error in unit(rep(0, TABLE_ROWS * dims[1]), "null") :
#> 'x' and 'units' must have length > 0`

^{Created on 2023-03-11 with reprex v2.0.2}

Add unit test: breaks and labels are different

Should consider adding a unit test for this:

df <- data.frame(col = c(0, 0, NA, NA, NA, NA, NA, NA, 0, NA))
expect_error(gg1d_plot(df, cols_to_plot="col1"), NA)

Since theres only 1 non-na value (0) an old version of gg1d would throw an error message about breaks and labels being different lengths. We fixed the issue but should add a unit test to catch future instances

If SampleID col is a factor, ensure there are options to set drop=FALSE/TRUE

will be required for integration with ggoncoplot package

Provide option to collect legends

guides = "collect" option to patchwork layout should do the trick. Should not do this by default, but should put on.

if collect_legends = TRUE, you should also show legend titles, add a message indicating show_legend_titles argument will be ignored

Add a way to ignore columns

I'm thinking an _ignore sufffix

implementation could be as simple as something like

ignore_suffix_found <- grepl(x=colnames(data), pattern = "_ignore$")
data <- data[!ignore_suffix_found]

Switch patchwork to cowplot to solve ylab alignment

Remove 'Remove N rows containing missing values (`position_stack()`)'

Occurs with numeric variables with NA values.

df <- data.frame(
col1 = c(0, 0, NA, NA, NA, NA, NA, NA, 0, NA)
)

Consider adding axis labels as axis text.

Using the solution described below, instead of adding Numerical Ranges to numeric y axes we could add the feature name.
If you use ggtext to be able to differentially format our text its possible we could get small text indicating range AND larger text in the middle describing the variable name

https://stackoverflow.com/questions/52123104/ggplot2-custom-categorical-labels-on-a-numerical-x-axis

selkamand / gg1d Goto Github PK

gg1d's People

Contributors

Watchers

gg1d's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs