[Feature] Manual serial port field for UDP fake PTY ports about pygpsclient

[semuadmin]

Hi Antonio, Thanks for this. I'm away from the office for the next few days but will certainly take a look at your suggestions when I return. Thanks -- semuadmin

…

-- semuadmin SEMU Consulting https://github.com/semuconsulting

________________________________ From: Antonio Vanegas ***@***.***> Sent: Monday, October 10, 2022 1:22:54 PM To: semuconsulting/PyGPSClient ***@***.***> Cc: semuadmin ***@***.***>; Assign ***@***.***> Subject: Re: [semuconsulting/PyGPSClient] [Feature] Manual serial port field for UDP fake PTY ports (Issue #34) I wrote a small guide<https://twitter.com/hpsaturn/status/1579405419050848256> to have virtual serial ports. This guide uses your script socker server<https://github.com/semuconsulting/PyGPSClient/blob/master/examples/socket_server.py> implementation and one virtual serial port. With this possible new feature, we could put direct the virtual serial port instead the socket server. It's only an idea. — Reply to this email directly, view it on GitHub<#34 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGZ7C36MEUEH4YZ3P5UBBIDWCP4A5ANCNFSM6AAAAAAQ7X563A>. You are receiving this because you were assigned.Message ID: ***@***.***>

[semuadmin]

Hi @hpsaturn

FYI I've added a PR containing the following enhancement:

Add provision to pass user-defined serial port designator via command line keyword argument port or environment variable PYGPSCLIENT_USERPORT.

e.g.

pygpsclient port=/dev/tty12345

or

export PYGPSCLIENT_USERPORT = "/dev/tty12345"
pygpsclient

Any user-defined port will appear in the serial port listbox as the first preselected item.

[hpsaturn]

I wrote a small guide to have virtual serial ports. This guide uses your script socker server implementation and one virtual serial port. With this possible new feature, we could put direct the virtual serial port instead the socket server. It's only an idea.

[semuadmin]

Hi @hpsaturn. Thanks for this, and sorry it's taken a while to get back to you.

Given the additional information you've provided on virtual ports, I'm not entirely clear what the outstanding issue is or what additional functionality you're after.

As you've presumably seen, the serial port listbox in PyGPSClient uses the standard Python serial.tools.list_ports.comports function to list the available serial ports. This is primarily intended for physical serial connections (i.e. USB or UART), and as a standard library function I have no direct control over its functionality.

I could, as you suggest, add a manual serial port entry facility, but since the listbox works for 99% of standard use cases I'm somewhat loath to complicate the UI for what would be a niche case. I could, as an alternative, provide an optional command line facility for manual port override e.g. pygpsclient port=/dev/pts/14.

As you've seen, PyGPSClient can also read directly from a TCP or UDP socket stream - have you actually tried reading your device's UDP stream directly using this facility, rather than coverting it to a virtual serial port using socat?

If you can clarify exactly what missing functionality you're after, I'm happy to investigate further.

[hpsaturn]

Hi @semuadmin

Thanks for your detailed explanation. I think that option on the command line or via an environment variable could works. Also I understand that this feature maybe nobody needs it, is a minor feature. With the command line option I wouldn't have to start the UDP server.

Regarding to try to read direct the UDP device stream, I need test again because didn't works. I tried many times on many ways. But let me test again, maybe I had some protocol mistakes..

[semuadmin]

Hi @hpsaturn Yes, suggest try the direct UDP/TCP socket and let me know how you get on. Purely out of interest, any particular reason why you favour UDP over TCP?

I take it you're working with IOT devices like the ESP32? I have in the past tested using a WROOM ESP32 with an old NEO-M6 GPS module connected via UART, transmitting a raw NMEA data stream via a TCP socket using the wifiserver.h Arduino library, and it did work fine with PyGPSClient's socket stream facility.

[hpsaturn]

Yes I will try again it. Regarding TCP/UDP, don't matter. I want map the UART output via TCP/UDP for other features. For example I have a CLI, and sometimes for debugging via UDP could be more fast without no matter lost some packets.. But again, let me try again to test the direct UDP/TCP socket again, for close this issue.

[hpsaturn]

Works like a charm!

(pvenv) (add-app-entry-kwargs) avp:PyGPSClientȹ export PYGPSCLIENT_USERPORT="/dev/pts/10" 
(pvenv) (add-app-entry-kwargs) avp:PyGPSClientȹ python3 -m pygpsclient

I will change my guide because with this improvement I don't need starting the socket server, I don't need the last part on the guide.

Thanks!

[Ve2mrx]

I'm in need of this workaround due to pyserial/pyserial#489, it blocks /dev/ttyS0 on which the GPS is present.
Unfortunately, I can't seem to get the tweak to work

Hi @hpsaturn

FYI I've added a PR containing the following enhancement:

Add provision to pass user-defined serial port designator via command line keyword argument port or environment variable PYGPSCLIENT_USERPORT.

e.g.

pygpsclient port=/dev/tty12345

or

export PYGPSCLIENT_USERPORT = "/dev/tty12345"
pygpsclient

Any user-defined port will appear in the serial port listbox as the first preselected item.

pygpsclient: error: unrecognized arguments: port=/dev/ttyS0

PyGPSClient 1.4.7
Python 3.9.2
Raspberry Pi OS 64-bit "Bullseye"

Thanks for your time,
Martin

[semuadmin]

Hi @Ve2mrx

Things have moved on a bit since this change was originally made. The easiest way to do this now is via a *.json configuration file e.g. pygpsclient.json. The following configuration setting in the file will take precedence over any command line arguments:

"userport_s": "/dev/ttyS0",

To create an initial default configuration file, simply use the 'File...Save Configuration` menu option.

Unfortunately it appears I've broken the command line parsing so the alternative pygpsclient --userport /dev/ttyS0 or pygpsclient -U /dev/ttyS0 command line argument (note updated syntax) doesn't currently work - a fix will go into v1.4.8: 13ec43b.

Hope this helps

[Ve2mrx]

@semuadmin Thanks, this fixed my problem!

Martin