sentinel-official / hub

The official Sentinel Hub blockchain

Sentinel Hub

For documentation click here

hub's Issues

Implement REST API routes

Fix queries

Separate out node subscription and plan subscription message

Error on Installation Linux Mint

Describe the bug
Installation don't can be startet

To Reproduce
Only download and try to install

Expected behavior
Error Message: Abhängigkeiten nicht erfüllbar: libgconf2-4

Screenshots

Desktop (please complete the following information):

• OS: [Linux Mint]
• Version [Kernel 5.8.0-53]

Add queries for querying the parameters of VPN modules

Limit number of nodes for a Provider

Add inactive period for providers

Validation for node's type, version, moniker, and encryption

• Type min 4, max 16 char length
• Version min 4, max 16 char length
• Moniker min 4, max 32 char length
• Encryption min 4, max 16 char length

make: *** [Makefile:43: mod-vendor] Error 127

build failed on clean ubuntu 20.04 machine.
go version go1.17.3 linux/amd64

/src/github.com/sentinel-official/hub# make install --debug
GNU Make 4.2.1
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
 File 'install' does not exist.
   File 'mod-vendor' does not exist.
     File 'tools' does not exist.
    Must remake target 'tools'.
    Successfully remade target file 'tools'.
  Must remake target 'mod-vendor'.
/bin/sh: 1: modvendor: not found
make: *** [Makefile:43: mod-vendor] Error 127

Improve state export, validation and import methods

Remove following fields from Node

• Moniker
• InternetSpeed
• Version
• Category

Write documentation for provider module

Need modifications in ID type

• Create an ID interface
• Need prefixes for node ids, subscriptions ids, and session ids

Added EndBlocker logic for subscription module

Move bandwidth signature data to hub types

Use separate KV stores for all modules

Add Identity field for Provider

Add the provider to signers while registering and updating node information

Write tests for provider module

Lack of seeds

Describe the bug
To join a network, people need seeds or peers, and currently there are none to be found.

To Reproduce
Join the testnet

Expected behavior
Seeds should be front and center in readme.md and they should later be baked directly into the binary.

Move app.go file to app package

Write tests for node module

Write tests for subscription module

Add pagination for queries

Remove unncessary methods for subscription keeper

• SetSubscriptionForNode
• HasSubscriptionForNode
• GetSubscriptionsForNode
• SetSubscriptionForPlan
• HasSubscriptionForPlan
• GetSubscriptionsForPlan

Added EndBlocker logic for node module

minimum deposit required for a proposal

Describe the bug
The mindeposit on the gov module required for a proposal to enter the voting period should be 512tsent, but with this ammount sent to the proposal, continues in Deposit Period.

To Reproduce
Sending the the minimum amount for the deposit period to pass, the proposal remains in the deposit period, you can found the proposal here with the min amount to proposal goes to voting period.

Expected behavior
If the minimum amount of 512tsent is reached, the process should enter the voting period.

Screenshots

• Version:

name: sentinel-hub
server_name: sentinel-hubd
client_name: sentinel-hub-cli
version: 0.3.3
commit: 706826e957c761409060ba17e25ad6854f4c50dd
build_tags: netgo,ledger

Add bandwidth allocation for subscription member

RPC very slow querying a lot of plans

Describe the bug
When a lot of plans are present on-chain, this endpoint is very slow https://sentinel-rpc.dimi.sh/plans and could lead in a terrible ux while using the dVPN desktop client

Expected behavior
Consider implementing a provider based search like /providers/{address}/plans

Need simulation for vpn module endblock logic

Note to Validators

Hi,

I'm operating a relayer. If you are operating a validator, it is very important that you:

systemctl enable systemd-timesyncd

please.

If you do not, there are time drift errors, and well, the Hermes default of five seconds is really pretty generous. We should be less than five seconds apart.

Potential overflow/denial of service in provider plan creation

Describe the bug
Right now the MsgPlanAdd generates the ID based on the count of plans in the keeper.

hub/x/plan/handler.go

Line 20 in 706826e

ID: count + 1,

uint64 limit is 18446744073709551615 so still quite hard to reach under standard circumstances, but still possible.

To Reproduce
The max throughput I'm able to reach is 8000 MsgPlanAdd per tx, which will cause an overflow in about 70k years. So not an urgent issue

Expected behavior
I suggest to let the client choose the plan-id and change the type from uint64 to string, using uuidv4. I can work on a PR if makes sense

Additional context
v0.3.3

Write documentation for subscription module

Limit number of nodes for a Plan

can't install sentinel hub software

can't install sentinel hub software by following official manual
https://github.com/sentinel-official/docs/blob/master/guides/testnets/turing-3/SETUP.md#step-2---installing-the-sentinel-hub-software

go get -u -d github.com/sentinel-official/hub

cannot find package "github.com/gogo/protobuf/grpc" in any of:
	/usr/lib/go/src/github.com/gogo/protobuf/grpc (from $GOROOT)
	/home/sent/go/src/github.com/gogo/protobuf/grpc (from $GOPATH)
cannot find package "github.com/cosmos/cosmos-sdk/x/supply" in any of:
	/usr/lib/go/src/github.com/cosmos/cosmos-sdk/x/supply (from $GOROOT)
	/home/sent/go/src/github.com/cosmos/cosmos-sdk/x/supply (from $GOPATH)
cannot find package "github.com/tendermint/tendermint/libs/bech32" in any of:
	/usr/lib/go/src/github.com/tendermint/tendermint/libs/bech32 (from $GOROOT)
	/home/sent/go/src/github.com/tendermint/tendermint/libs/bech32 (from $GOPATH)
cannot find package "github.com/cosmos/cosmos-sdk/client/context" in any of:
	/usr/lib/go/src/github.com/cosmos/cosmos-sdk/client/context (from $GOROOT)
	/home/sent/go/src/github.com/cosmos/cosmos-sdk/client/context (from $GOPATH)
cannot find package "github.com/cosmos/cosmos-sdk/x/auth/client/utils" in any of:
	/usr/lib/go/src/github.com/cosmos/cosmos-sdk/x/auth/client/utils (from $GOROOT)
	/home/sent/go/src/github.com/cosmos/cosmos-sdk/x/auth/client/utils (from $GOPATH)
cannot find package "github.com/tendermint/tendermint/libs/common" in any of:
	/usr/lib/go/src/github.com/tendermint/tendermint/libs/common (from $GOROOT)
	/home/sent/go/src/github.com/tendermint/tendermint/libs/common (from $GOPATH)

** OS ubuntu 18.04

Added module wise logger

Use scheduling method for ending a subscription

Need genesis validations for deposit, and vpn modules

Improve logging in the end blocker logic

Write documentation for node module

Optimize pagination of queries

Improve Events

Add node's trust period

Optimize the update node transaction message

Cache the module parameters in the keeper struct

Make the remote URL of the node as not required

dVPN nodes are failing to update bandwidth for inactive sessions

Derive dVPN node price per GB based on MA of last N subscriptions

Remove REST API endpoints

Allow node to remove itself from a plan