serabakpak / happy-hour Goto Github PK

Project 1 Feedback

Student: Sera and Laura

Scoring Key
0 - "Does Not Meet Expectations"
1 - "Meets Expectations"
2 - "Exceeds Expectations"

Project Planning - 1.3

• Descriptive README.md: 2
• Detailed Wireframes: 1
• Exhaustive User Stories: 1
• Realistic database structure [ERD]: 1

Nice readme screenshots!

Creativity - 2

• Visually Polished: 2
• Personal Spin: 2

The site looks excellent visually! The slideover effect gives a really nice first impression, the font is clean, and you leave ample open space on the page. The one piece I'd critique as far as its visual properties would be the reviews section.

The buttons seem crowded on one another and the corners of the cards are sometimes rounded, sometimes right angle. The cards could also probably be spaced apart a bit to give a little more room. I mention this, because it's noticeable with everything else looking so sharp!

Project Workflow - 1.5

• Frequent Commits: 2
• Effective use of branches: 1
• Deliberate Approach: 2
• Original Code: 1

Commit chart matches the fact that you paired on the whole project alternating who was driving. Each person made a substantial number of commits while driving!

As far as branching goes, you did well branching and then merging changes into master. The structure does look a bit unusual. The blue branches in this image follow a more typical pattern: branch from master, merge it in and then leave the branch behind. The green branches are a bit more unusual, where it seems that you merge into master after every commit. On a new branch, work to complete a feature and THEN merge it into master. Then start a new branch for the new feature you'd like to build. This type of workflow feedback is certainly information feedback and isn't necessarily really important in every work environment.

Execution - 2

• Code is visually clean: 2
• Follows good naming conventions: 2
• Code is free of obvious errors/bugs: 2
• Code demonstrates a solid understanding of language fundamentals: 2
• Code demonstrates good problem solving and effective use of the standard-library: 2
• Code is DRY: 2

In public/scripts/show.js, lines 24-101 seem unusually indented in a way that impacts reading. When I see code so indented, I think it's all nested within many different functions, which would indicated poor organization. It seems here that the code is organized other than the indentation! You wouldn't want somebody thinking that you have poorly organized code when you actually have well organized code that's indented unconventionally.

There also seems to be some "extra" indentation on index.html.

The <header> tag, for example, seems much further indented than it needs to be, compared to the <script> tags you can see above in the head.

I like that you divided out the CSS files for each view.

Nice that you have API documentation! It's well organized and hosted in a logical place.

There is a large chunk of commented out code in the reviewsController. It's fine to have unfinished code commented out, but add an explaining comment to state why it's commented out. Using /this comment syntax/ is common prior to any function or piece of code that's fully commented out.

Technical Requirements - 1

• Code works (and will work in production): 1
• Full CRUD: 5/5 [index, show, create, update, destroy]

• Express API
• RESTful Routes
• AJAX
• jQuery
• Templating
• MongoDB - Persist at least two resources to a MongoDB database. One resource must have full CRUD.
• Visual Design
• Code Style
• Git
• Heroku
• Documentation

Flex requirements

• Bootstrap/Foundation
• data validation
• extra model relationships
• external APIs
• Sessions

Student Success - 1.5

• This project demonstrates mastery of class material: 1
• This student is proactive about reaching out / asking questions / getting help: 2

Whenever I came over, you were both really descriptive of the problem that was going on. You'd done some excellent troubleshooting and gave me the details of the solutions you'd attempted. This helped us be productive whenever you asked me to stop by for assistance. It also provided evidence that you'd worked particularly well together!

Summary
Again, you worked as a stellar team on this project. You collaborated on every piece throughout, even on the explanations when I came by (sometimes finishing one another's explanations). The feedback I've given above is to give you a more detailed comb through the project to find the very few things that might be adjusted for improvement in the future. I'm looking forward to seeing the work that you both build in the weeks ahead!