Files served before copy is complete about compact

[serby]

I've never had this error. I'll try the upgrade and you can let me know if it fixes it.

[TrevorBurnham]

Hmm, I tried the pipe method and am still getting the same error. Definitely a bug somewhere beyond this library.

[TrevorBurnham]

After much frustration, I finally figured out the issue: The problem was that I was using the middleware in the order

app.use(compact.middleware(...));
app.use(express.static(...));

In which case, the compact middleware will recopy the files on every request (in debug mode)—including the requests to retrieve those files from the cache! The result is that the files are copied over as they're being served, leading to random errors.

The best workaround is to only use the compact middleware on requests for pages (swapping the order of the middleware should effectively do this), though this means that you have to load a page in order to see changes you've made to a script, which isn't ideal.

[serby]

I think the reason I don't observe this is because for my uses I don't use the global middleware and I don't have a need to view the compacted scripts.

By always applying compact on specific routes it will always be loaded after the static middleware.

[TrevorBurnham]

Makes sense. Might not be a bad idea to update the README, though. Other precompiler middlewares (like Stylus') are supposed to come before the static middleware, so I assumed compact's was as well.

On Nov 2, 2012, at 7:48 PM, Paul Serby [email protected] wrote:

I think the reason I don't observe this is because for my uses I don't use the global middleware and I don't have a need to view the compacted scripts.

By always applying compact on specific routes it will always be loaded after the static middleware.

—
Reply to this email directly or view it on GitHub.

[serby]

Done.

[TrevorBurnham]

You're a gentleman and a scholar.