serby / compact Goto Github PK

View Code? Open in Web Editor NEW

50.0 50.0 14.0 86 KB

A simple JavaScript compacting middleware for express

JavaScript 98.76% Makefile 1.02% HTML 0.23%

compact's People

Contributors

Stargazers

Watchers

Forkers

iamsmith microadam jackbrewer bengourley skimberk oliverjohnstone voronchuk node-migrator-bot zhuzhuaicoding dommmel gdiab rymate1234 mantasmikal

compact's Issues

The version of uglify-js used has vulnerabilities

https://nodesecurity.io/advisories/39
https://nodesecurity.io/advisories/48

Can't pass options through to Uglify

This means some JS libs can't be used with compact safely, e.g Jade. See mishoo/UglifyJS#361

Files served before copy is complete

When I have multiple scripts and I use compactJsHtml() in debug mode, I often get

Uncaught SyntaxError: Unexpected end of input

in my browser console for one or more scripts. It turns out that the script hasn't been completely copied from src to dest before the page is served.

I see that the copying is being done using util.pump, which has been deprecated in favor of stream.pipe. So that may fix the issue.

Any way to have the file regenerated when src files change?

Looks good, but is there a way to have it regenerate each time the underlying code changes? Looks like I have to restart the server each time. But I'm new to node and so maybe I'm "doing it wrong."

Thx

Multiple compactJsHtml functions

Because there's only one compactJsHtml function, compact doesn't allow you to create, say, one set of JS files to be concatenated in the <head> and another set to be concatenated at the end of the <body>.

How about an API that looks like this:

// Express configuration
app.use(compact.middleware({
  head: ['namespace1'],
  foot: ['namespace2']
});

// Jade template
html
  head
  != compact.head.html()
  body
    block content
    != compact.foot.html()

Wrong Should.js code pulled in...

The ThrowError code is missing from should lib.

If you clone the latest version of should.js and copy the should.js lib file over the top of the exciting one. The Tests run fine.

But installing it from npm does not seem to bring in the lastest version.

Test needed for namespace sourcePath addNamespace(..., sourcePath)

Using with Express 3.x

Just a quick heads up that anyone wanting to use this on Express 3.x needs to change line 201 in compact.js as app.helpers are not used anymore. You simply have to change it to app.locals

I would create a pull request but it seems trivial for one simple word change

Third-party scripts (Feature)

It would be nice to have a feature in compact that lets you reference third party scripts.. e.g jQuery on Google's CDN, Google Maps API, various share widgets (Twitter, +1, Facebook).

e.g:

compact.addNamespace('find-us')
    .addThirdPartyJs('http://maps.google.com/maps/api/js?sensor=true')
    .addJs('/js/my-map.js');

Output:

<script src='http://maps.google.com/maps/api/js?sensor=true'></script>
<script src="/js/compact/find-us.js"></script>

Similar functionality is easily achievable with Jade template inheritance, but I think it would be better if all of the frontend JS was organised in one place. What do you think?

Doesn't work on a windows server with FF14 client

The slashes in the script tag become \ in windows and FF doesn't correct it
It seems to work after changing filename in line 255 to
filename.split(path.sep).join('/')

Timestamp update on compacted JS on each request

Trying to migrate from minj and I encountered this issue...

Every time I request a page in the browser, the timestamp of the compacted js file(s) is updated. This was causing nodemon to restart the server on each request. I've added the compated directory to my .npmignore which prevents this issue, but I am confused as to why the timestamp is updated, and don't think it should be.

Scripts not in order

I'm adding scripts (using addJs()) to my namespace, but in the compacted file, the order isn't maintained. Example:

compact.addNamespace('edit');
compact.ns.edit
    .addJs('ace/ace.js')
    .addJs('ace/mode-html.js')
    .addJs('ace/mode-css.js')
    .addJs('ace/mode-javascript.js')
    .addJs('edit.js');

The scripts are added to the compacted file in this order: mode-html.js -> mode-css.js -> mode-javascripts.js -> edit.js -> ace.js

I was wondering if there is any way to fix this? Thanks.

app.js

app.get('/', routes.index); // No JS on page
app.get('/edit', compact.js(['edit']), routes.edit); // `edit` JS on the page

layout.jade (inherited by index and edit views)

//...
if (compactJsHtml !== 'undefined')
  !=compactJsHtml()
//...

If you view / then the page is output as desired: no JS.
If you view /edit then the page is output as desired: edit JS
Subsequent views to / output the edit JS because compactJsHtml is still defined from the request to
/edit

path.existsSync...

path.existsSync is now called fs.existsSync

serby / compact Goto Github PK

compact's People

Contributors

Stargazers

Watchers

Forkers

compact's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs