serendipity-theme / vs-code Goto Github PK

When the theme is active the syntax highlighting stops working in polyglot notebooks.

Before activating:

and after:

Hi and thanks for an amazing theme! ❤️

I noticed Python docstrings are colored as purple. This not only takes up very much focus from the actual code but all other comments seems like they are intended to be gray. I've added a small workaround for now in my settings.json but maybe this is something which should be fixed in the theme itself?

{
    "editor.tokenColorCustomizations": {
        "[Serendipity Dark]": {
            "textMateRules": [{
                "scope": "string.quoted.docstring.multi.python",
                "settings": {
                    "foreground": "#5c6773"
                }
            }]
        }
    }
}

You can reproduce this by just looking at a python script with a docstring:

def x():
    """Some docstring here."""
    return None

First of all, thank you for this awesome color theme!

I made some changes to my settings.json file to have a little more contrast and this is the result:

Feel free to make "High Contrast" options based on this customization if you wish.

    "workbench.colorCustomizations": {
        "[Serendipity Morning]": {
            // Base Color #FDFDFE
            "tab.activeBorder": "#FDFDFE",
            "tab.activeBackground": "#FDFDFE",
            "titleBar.inactiveBackground": "#FDFDFE",
            "list.inactiveSelectionBackground": "#FDFDFE",
            // Focus High #949ABE
            "tab.activeBorderTop": "#949ABE",
            // Overlay Color #D8DAE4
            "tab.hoverBackground": "#D8DAE4",
            "tab.hoverBorder": "#D8DAE4",
            "sideBar.border": "#D8DAE4",
            "statusBar.border": "#D8DAE4",
            "activityBar.border": "#D8DAE4",
            "editorGroupHeader.border": "#D8DAE4",
            // Interface Color #F1F1F4
            "editorGroupHeader.tabsBackground": "#F1F1F4",
            "sideBar.background": "#F1F1F4",
            "statusBar.background": "#F1F1F4",
            "statusBarItem.remoteBackground": "#F1F1F4",
            "activityBar.background": "#F1F1F4",
            "titleBar.activeBackground": "#F1F1F4",
            // Coral #D26A5D
            "tab.activeModifiedBorder": "#D26A5D",
        },
        "[Serendipity Sunset]": {
            // Base Color #FDFDFE
            "tab.activeBorder": "#202231",
            "tab.activeBackground": "#202231",
            "titleBar.inactiveBackground": "#202231",
            "list.inactiveSelectionBackground": "#202231",
            // Focus High #949ABE
            "tab.activeBorderTop": "#535568",
            // Overlay Color #D8DAE4
            "tab.hoverBackground": "#363847",
            "tab.hoverBorder": "#363847",
            "sideBar.border": "#363847",
            "statusBar.border": "#363847",
            "activityBar.border": "#363847",
            "editorGroupHeader.border": "#363847",
            // Interface Color #F1F1F4
            "editorGroupHeader.tabsBackground": "#272938",
            "sideBar.background": "#272938",
            "statusBarItem.remoteBackground": "#272938",
            "statusBar.background": "#272938",
            "activityBar.background": "#272938",
            "titleBar.activeBackground": "#272938",
            // Coral #D26A5D
            "tab.activeModifiedBorder": "#D1918F",
        },
        "[Serendipity Midnight]": {
            // Base Color #FDFDFE
            "tab.activeBorder": "#151726",
            "tab.activeBackground": "#151726",
            "titleBar.inactiveBackground": "#151726",
            "list.inactiveSelectionBackground": "#151726",
            // Focus High #949ABE
            "tab.activeBorderTop": "#535568",
            // Overlay Color #D8DAE4
            "tab.hoverBackground": "#232534",
            "tab.hoverBorder": "#232534",
            "sideBar.border": "#232534",
            "statusBar.border": "#232534",
            "activityBar.border": "#232534",
            "editorGroupHeader.border": "#232534",
            // Interface Color #F1F1F4
            "editorGroupHeader.tabsBackground": "#1C1E2D",
            "sideBar.background": "#1C1E2D",
            "statusBar.background": "#1C1E2D",
            "statusBarItem.remoteBackground": "#1C1E2D",
            "activityBar.background": "#1C1E2D",
            "titleBar.activeBackground": "#1C1E2D",
            // Coral #D26A5D
            "tab.activeModifiedBorder": "#EE8679",
        },
    },
}`

The latest update to the light color scheme seems nice, The blue border upon debugging/testing was a nice touch. However I did notice that the color scheme for some text in the intergrated terminal got blended to the background.
I'm using gh cli for reference.

Hi there 👋🏼

I found a problem within the "Source Control" tab that does not allow the "input box validation" to be seen (because it has 0% opacity)

This is due to the color used in the inputValidation.warningBackground property, for example, changing this to another one you can see it correctly

The same thing happens with properties inputValidation.infoBackground and inputValidation.errorBackground, and probably others, because #0000 takes 0% opacity.

If you wish, I can create a PR with the colors you think are appropriate.

Right now it is highlighted with pink on pink color and it is not really legible.
Is there setting to override that?

So here are a few things to look into:

• Properties (RED SQUARE) - seems like in serendipity they are light purple right now which is not very distinguishable from the function definition purple. Furthermore, when the prop is being called again, it is not highlighted (see example of "result" on the screenshots)
• Components (BLUE SQUARE)- usually uses a separate color
• String interpolation inside ${} (PURPLE SQUARE) - same as variable but it seems that variables overall are not highlighted right now - thus they are not being highlighed when used further. (see BASE_URL example on comparison with Dracula).
• Paths (YELLOW SQUARE) - have been resolved to orange already as what I have seen from the last update.

Hi again! 👋

When I'm comparing files or performing diffs in vscode with the serendipity midnight theme, I get a border around each line which was changed (and even borders around individual parts of a line). This makes comparisons/diffs incredibly noisy and hard to read - and is everything but minimal 😉 . I can provide a screenshot for you if you like (currently working on proprietary code while writing this).

You can compare with a regular diff in GitHub which only has a red/green background color (no border around each and every changed line) which looks a lot cleaner (but using a less compelling theme).

I think an improvement would be to leave the background color as-is for the code that changed, but remove the borders. What do you think?

Hi, I found this small confusing thing:

This line of code in Go, is not an error, it's a warning from the MongoDB library. Many themes underline this in yellow/orange color to signify a warning. But here, it is really close to the red error-like color.

It is normal or should this be changed?
Thanks 😀

Greetings! First, love the work. Great job all around.

That said, I wanted to inform you there's a possible typo in the label for the theme "Serendipity Midnight" in VSCode.

It looks like there's an extra space between the words in package.json here.

Hope that's helpful! Again, awesome stuff.

Hi, and thanks for a super nice theme!

I'm having great difficulties identifying where horizontal/vertical divider/separators are located. I struggle to find the exact location with the mouse and it becomes frustrating.

You can see in this screenshot, for example, that the vertical draggable divider is somewhere left of the line numbers. But where, exactly?

When I bring up the terminal, it gets easier to see exactly where this is, as the invisible divider line is exactly at the left end of the terminal:

Some ideas of what I could potentially do about this:

• Figure out the styling syntax to override the color of the divider, so it become visible
• Figure out the styling syntax to override the background color of the explorer/side bars, and make them slightly darker than the code area background

I'm leaning towards the latter, and I just added some custom styling to my settings.json for this:

  "workbench.colorCustomizations": {
    "[Serendipity Midnight]": {
      "sideBar.background": "#121421"
    }
  }

Maybe you'd like to consider building something like this straight into the theme?

Hi. What happened to the old color schema? I've been using Serendipity Dark for a long time and after the latest update it's gone and the new colors came. Is it possible to use the previous colors?

@BD103 bro i found this theme on dev.to I think...I didn't even know you helped make it. Amazing job bro! I love it

Can you maybe create the website that your image is based off? I know it is only a Figma design, but that website would look fire if you made it, and it would be easier to test out the theme on the website (with like maybe a 'fake' vs code that changes when you toggle the theme).

Anyway, your theme was the first change from one dark pro in almost a year so good job making me leave one dark pro!

First, thanks for this excellent theme!

I want to know if you have in mind supporting Jetbrains IDE's aka. IntelliJ, RubyMine, etc

Why am I getting this?

It looks horrible if it was deliberate I recommend you change that...

Can you please publish serendipity & serendipity old on open vsx so I can use this on gitpod

Hi, you've got a missing e in theme in your headline:

I looked for the website's source code but could not find it so I'm reporting this here

The italics versions were removed as part of the name changes (dark->midnight and such) was this on purpose?

As a side note, I found the original scheme to be a bit more readable. The current update removed the contrast between the sidebar and editor. Would you consider an additional option to include the original "Dark/Dark Italic" theme? :)

I use markdown files frequently, and I used to use One Dark Pro as my theme before this. The one dark pro theme for markdown just looks better to me - and I think it is because the headings have bold to them while your headings don't. I hope maybe you can give a little bold to your headings to differentiate themselves from the rest of the text.

Also for some reason in One Dark Pro, the text size is bigger in markdown files than all the other extensions. If you could give an option in settings to also enable this it would be nice so I could have enlargened text for the markdown previews of files!