sergegoussev / pysqlc Goto Github PK

db.py has two unique things: connecting to the db and querying data. These should be separate objects with the db as parent, and another one as child that is inherited

pysqlc does not utilize the SHA2 encryption method. The current connection is made using the legacy mysql native password:

self.conn = mysql.connector.connect(
                host=self.login['host'],
                user=self.login['username'],
                password=self.login['password'],
                port=self.login['port'],
                charset=self.login['charset'],
                database=None,
                auth_plugin='mysql_native_password'
            )

For now, this gets around the Authentication plugin 'caching_sha2_password' is not supported error that is sometimes raised when connecting to SHA2 encrypted DB environments.

TO DO:

• Refactor the connect() method to accept SHA2.

For more info, see:

• https://dev.mysql.com/doc/connector-python/en/connector-python-connectargs.html
• https://stackoverflow.com/questions/50557234/authentication-plugin-caching-sha2-password-is-not-supported

Prior to executing a query, pysqlc validates what type it is so as to not let users use a q_type='SELECT' (default) when a value insert is required. This is done by simply scanning the inserted sql query for main CRUD commands.

I.e. if any mod_qs = ('update', 'insert', 'replace', 'delete', 'create') are present, then the user must specify values and the q_type.

This could create conflict if there is a column being queried in a database that contains any of these columns:

---------------------------------------------------------------------------
QueryError                                Traceback (most recent call last)
<ipython-input-12-05a69d7a9b1c> in <module>
----> 1 data_community_0 = db.query(q_twts_community_0, q_type="SELECT")

~\Anaconda3\envs\e36\lib\site-packages\pysqlc\db.py in query(self, sql_query, values, q_type, executemany)
     68             else:
     69                 raise QueryError(
---> 70                     'improper q_type, please do not use SELECT when modifying data')
     71 
     72 

QueryError: improper q_type, please do not use SELECT when modifying data

Fix this potential conflict

Write unit tests to validate that features work properly.

Specifically, test:

• connecting with env variable
• connecting manually
• querying data (test all CRUD methods)
• timeout on connection