sergiocruz / ng-karaoke Goto Github PK

First of all, this is very good demo app. Karaoke is awesome.

I found an issue about the lyrics and speech match.

In the app, you used the SpeechRecognition to record the sound, returned the transcript text to PlayerComponent and match the text to the current lyrics line.

But if you keep singing a line by a line, the SpeechRecognition would keep recording the sound and SpeechRecognitionResult.isFinal would always be false. This caused the SpeechComponent did not emit any transcript text to PlayerComponent. But as the song goes, the array holding the lyrics lines in PlayerComponent would keep refreshing. Once in the middle of the song where there is only music and no lyrics and you stop singing, the SpeechRecognitionResult.isFinal would be true and return the text to PlayerComponent. But the line array in the PlayerComponent might be completely different with the text. This would makes the calculation of the match points incorrect. You could simply reproduce this issue as you keep singing the lyrics correctly.

I think this is one of reasons why your demo in ng-conf did not calculate any points when one of your audience was singing on the stage.