serilog-contrib / serilog-settings-xml Goto Github PK

Details here: serilog/serilog#1020

The configuration sample on the front page didn't work for me - no File sink got created.
Eventually, after a long time!, I worked out that needed to be added to the using section.
I know you guys would have realised that immediately but I am a newbie to serilog.

Also, the Xml extension method allows a null filePath but the XmlSettings ctor throws if it is null.
Can I suggest that a null filePath doesn't throw but instead Configure(), on seeing a null filePath, gets the xml from the config file instead: Its the identical Xml section and still goes to create identical KeyValuePairs, just from a different place.
(I know this works because I copied your code - since it is sealed and non-virtual - and tried it out)

It would be great to have xsd schema for autocomplition in Visual Studio as it done on NLog and log4net.

Probably it must be separate package.

On a LoggerConfiguration instance, I can't find a way of getting the MinimumLevel LogEventLevel.
Either from the _minimumLevel field or the MinimumLevelConfiguration - neither has anything public.

Reason for needing it:
I create a LoggerConfiguration from the app.config file and now want to set it's MinimumLevel.ControlledBy to a LevelSwitch but I can't pre-initialize that LevelSwitch with the current LogEventLevel as it is hidden away.

https://github.com/serilog/serilog-filters-expressions

Some sink implementations using the name of sink name which is different from namespace. To support this we need to introduce value in using part of the config.

Here is example for https://github.com/saleem-mirza/serilog-sinks-azure-analytics.

app.config way of configuring:

<appSettings>
  <add key="serilog:using:AzureLogAnalytics" value="Serilog.Sinks.AzureAnalytics" />
 </appSettings>

Expected xml way of configuring:

<serilog>
  <using>
    <add key="AzureLogAnalytics" value="Serilog.Sinks.AzureAnalytics"/>
  </using>
</serilog>

Having only value should be still supported:

<serilog>
  <using>
    <add value="Serilog.Enrichers.Thread" />
    <add value="Serilog.Enrichers.Process" />
    <add value="Serilog.Sinks.Seq" />
  </using>
</serilog>