GithubHelp home page GithubHelp logo

sfu-dhil / circus Goto Github PK

View Code? Open in Web Editor NEW
0.0 1.0 4.0 8 MB

A bibliography of national songs and the romantic era circus.

Home Page: https://dhil.lib.sfu.ca/circus

License: GNU General Public License v2.0

PHP 42.52% JavaScript 26.78% SCSS 10.06% Twig 18.07% Makefile 1.85% Dockerfile 0.71%

circus's People

Watchers

 avatar

circus's Issues

Search form should stay open

Is your feature request related to a problem? Please describe.
From LD: I was also wondering about whether the default search page could be the more detailed search? I think that would be most helpful to people conducting searches

Double Clippings Records

Describe the bug
There are double records that show up on the Clippings page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Clippings from the Circus home page
  2. Take note of:
  • IMG_8474 1 and 2
  • IMG_8485
  • IMG_3414
  • IMG_3426
  • IMG_3266
  • IMG_3268
  • IMG_4743
  • IMG_8563
  1. Click through to page 2
  2. See duplicates

Expected behavior
No duplicates!

Desktop (please complete the following information):

  • OS: iOS
  • Browser: Chrome

Additional context
This problem persists on page 3. All records below can be found on page 1 and page 3.

  • IMG_8474 1 and 2
  • IMG_8485
  • IMG_8498
  • IMG_8499
  • IMG_8583
  • IMG_3414
  • IMG_4655
  • IMG_3426
  • IMG_3468
  • IMG_3303

'Created by...' on About and Bib pages

Describe the bug
There's a 'created by Michael Joyce' on the About and Bib pages. Not sure if this is a bug, but seems like it shouldn't be there!

To Reproduce
Steps to reproduce the behavior:

  1. Go to About page

  2. See error

  3. Go to Bib page

  4. See error

Desktop (please complete the following information):

  • OS: iOS
  • Browser: chrome

Additional context
This also has nothing to do with anything, really, but is the paragraph on the bib page the only thing that's going to be there? If so, we should consider changing this. It's misleading!

Image-centre style required

Is your feature request related to a problem? Please describe.
There should be a way to centre images in the WYSIWYG text editor. Right now there's only an image-left and image-right.

Describe the solution you'd like
Image-centre image style

Describe alternatives you've considered
Not centering images, manually adding the necessary css etc. Not good.

Additional context
This would be useful in a lot of contexts, not just blog pages, and not just Circus.

Search result highlighter mangles non-ascii UTF-8

Describe the bug
Search result highlighter mangles non-ascii UTF-8.

To Reproduce
Steps to reproduce the behavior:

Go to https://dhil.lib.sfu.ca/circus/clipping/search?q=horse
Look for 'clock' in the search results.
The curly apostrophe is broken by the code that highlights horse.

Expected behavior
Properly curly apostrophe.

Search Clippings should just be Search

Describe the bug
We don't use the term "clipping" anymore in any of the public text on the website, so we shouldn't have that on the search page.

To Reproduce

  • Click on the search page
  • Notice the offending "Clippings" in the page header

Expected behavior
Remove the word "Clippings" from "Search Clippings"

Search Improvements

Is your feature request related to a problem? Please describe.
The search system is too simple.

Describe the solution you'd like
Searching based on all the fields of a clipping, including full text, date, number, and volume.

Stop cutting off horses

The horses in the header are cut off at various screen widths, since the background image is responsive. LD wants the horses to be visible at much as possible without being cut off.

Remove View All from Menu

Describe the bug
The view all option in the archive menu isn't particularly helpful and it's better to view all of the items via their sources or categories.

To Reproduce

  • Click view all
  • Behold unhelpfulness

Expected behavior
It shouldn't exist as a default menu option.

Display a more meaningful field instead of camera-assigned filename

Describe the bug
All clippings are labelled by the camera-assigned file name. I'm not entirely sure that this is a bug, but it seems like it might be? On the home page, the camera-assigned file name is under the image below the gallery.

To Reproduce
Steps to reproduce the behavior on the home page:

  1. Go to Circus home page
  2. See error.

Steps to reproduce the behavior on the Clippings page:

  1. Go to Clippings page
  2. See error

Expected behavior
Not sure if this is an error!

Desktop (please complete the following information):

  • OS: iOS
  • Browser: Chrome

Eliminate Dropdown Menu under Clippings

Describe the bug
Dropdown under 'Clippings' that only has 'Clippings' in it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Circus home page
  2. Click 'Clippings'
  3. See error

Desktop (please complete the following information):

  • OS: iOS
  • Browser: Chrome

Order clippings by handwritten number, date, then id.

Describe the bug
The ordering on the clippings is arbitrary and strange. It should be by number, date, then id.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the clippings list, a category page, or a source page.
  2. See error - the clippings are ordered by id or date.

Move Search with Icon to nav menu

As discussed with LD 2020-02-13: Move the search link to the header nav menu. Since there's no input box (it's just a simple link), it makes most sense to place in the header with the rest of the navigation items.

This means it should go in the footer, too.

Enable better paging system for Clippings results

Is your feature request related to a problem? Please describe.
Right now, when you're on every clippings page, you see "Displaying 25 clippings of 2948 total."

Describe the solution you'd like
It would be really great to make this clearer for users!

Describe alternatives you've considered
"Displaying 1 - 25 clippings of 2948 total" and then "Displaying 26 - 50 clippings of 2948 total"

Order and Name of Search Fields

Describe the bug
The order and name of some search fields needs to be adjusted.

  1. The Transcription Search field should be keyword or phrase or query or something.
  2. The order should be
Search term (or whatever it is named)
Date Written Date Number
Category Source

Make homepage editable

Right now, the homepage text content is hardcoded, but it should be editable by the Circus team.

Provide an easy way for users to access the Category Page

Describe the bug
Though the 'Category' tab is apparently hidden in the admin side, you can easily get to it through the Manuscript category list! Because the nav bar tab is hidden to the public, this is the only way you can get to category page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Clippings.
  2. Click on the first clipping.
  3. Scroll down and click 'Manuscript'
  4. Click the 'Back' button in the top-right corner of the page
  5. This is the only way to get to the category page!

Expected behavior
There should be another, easily accessible way to get to this page for the public.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: iOS
  • Browser: chrome

Additional Information
The fact that the button to get to this page is 'Back' is also a little confusing! I expected to be brought back to the record, not to the category page.

Search form is missing order-by options

Describe the bug
The search results are sorted by ID. There should be other ways to sort.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the search page
  2. Note the lack of order options
  3. Do a search
  4. See that the results are sorted by ID.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.