sgl0v / tmdb

iOS application for the Movie DB

TMDb iOS Application

This is the demo project of the article written in my blog. The application works as a mobile client for The Movie DB. It follows MVVM software design pattern and is built with Combine framework.

tmdb's Issues

Template for MVVM-C?

Hi again. This is not really an issue but rather an idea. Maybe it's nice if we could create a template for this architecture. A sample of a guide for creating an Xcode template: https://www.hackingwithswift.com/articles/158/how-to-create-a-custom-xcode-template-for-coordinators

Implement router or coordinator?

Thanks for this. This is perfect, I mean almost, I've been looking for an easy-to-read sample UIKit project with Combine + MVVM-C. Nevertheless, I appreciate the blog and you providing the whole project.

Catch will never get executed.

Awesome repo. Thank you, sir.

I have a question rather than an issue.

In Publisher+Utils.swift, I get a warning that the .catch will never get executed (Xcode Version 12.5 beta 3).

Any suggestions to fix that warning?

Thanks and regards.

extension Publisher {
...
    static func just(_ output: Output) -> AnyPublisher<Output, Failure> {
        return Just(output)
            .catch { _ in AnyPublisher<Output, Failure>.empty() }
            .eraseToAnyPublisher()
    }
...
}

Posters get reset

The current state of the project is that whenever the cell gets reused, we cancel the image loading and set the image of the poster imageView to nil, which causes the blinking of the imageViews when scrolling.
Is there a way to prevent this? Even if I integrate an imageLoader library (eg. MapleBacon) with caching and Combine support, the issue is still there (even if you remove the cancelImage loading).

It seems the really ideal way to async-ly load an image to reusable cells is to not use Combine? And rather directly download the image to the imageView.

Demo:

See the fix in the PR: #3